Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more explicit error on service create #1450

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Add more explicit error on service create #1450

merged 2 commits into from
Oct 31, 2019

Conversation

krhubert
Copy link
Contributor

close #1390

@krhubert krhubert added the enhancement New feature or request label Oct 30, 2019
@krhubert krhubert added this to the next milestone Oct 30, 2019
@krhubert krhubert requested a review from NicolasMahe October 30, 2019 22:32
@krhubert krhubert self-assigned this Oct 30, 2019
NicolasMahe
NicolasMahe reviewed Oct 31, 2019
View reviewed changes
sdk/service/sdk.go Outdated Show resolved Hide resolved
@krhubert krhubert force-pushed the fix/service-tx-exists branch from fcc8cec to 75fa8c6 Compare October 31, 2019 12:13
@krhubert krhubert merged commit 13542a6 into dev Oct 31, 2019
@krhubert krhubert deleted the fix/service-tx-exists branch October 31, 2019 15:51
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Nov 26, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@krhubert krhubert

Labels
enhancement New feature or request release:add Pull requests that add something
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Improve errors on the service create api
2 participants
@krhubert @NicolasMahe