Override default staking module config #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NicolasMahe
commented
Jan 15, 2020
NicolasMahe
commented
- Override default staking module token denom and power reduction.
- Put all cosmos config in config package.
…all cosmos config in config package.
NicolasMahe
commented
Jan 15, 2020
antho1404
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
I don't like the fact that some critical configs to configure cosmos are in the user config like the address prefix, coin name etc... This should be a decision that the engine enforces.
I'm ok to merge this as it will make our testing easier but this will need to move.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.