Switch to json logger in orchestrator and daemon #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
commented
May 20, 2020
| Use: version.ServerName, | ||
| Short: "Engine Daemon (server)", | ||
| PersistentPreRunE: func(cmd *cobra.Command, args []string) error { | ||
| if err := server.PersistentPreRunEFn(ctx)(cmd, args); err != nil { |
There was a problem hiding this comment.
I wraped the function server.PersistentPreRunEFn because it does some stuff using private function and it replaces the context.Logger inside the function (even if the logger is already initialized..)
NicolasMahe
added
the
release:change
antho1404
requested changes
May 20, 2020
|
I merged #1832 and cleanup a little bit. starting lcd # this is from the dev-starter script. could be switch to JSON if needed.
starting orchestrator # same
...
stopping all child processes # same
ERROR: accept tcp [::]:1317: use of closed network connection # don't know where exactly is outputing this |
antho1404
approved these changes
May 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1823
Switch to json logger in orchestrator, daemon and lcd:
{"_msg":"starting ABCI with Tendermint","level":"info","module":"main"} {"_msg":"Executed block","height":510,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"4E9912FCD1486857359370FF09C2A1920F96130D2DF05FA314923200C8D8AB72","height":510,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":511,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"B16E3C8548A8A461923B4D79614AEC3DCFD514DC7F72BDB9CE64D0B6EDC0ECCC","height":511,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":512,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"C707D02D52580949FCCC3B7ABFF1123A85D5E5493B1A284F00D18AF75F729766","height":512,"level":"info","module":"state","txs":0} starting lcd starting orchestrator {"_msg":"Executed block","height":513,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"EBE1EC3D2811772A4FE2C823CF167572729259A86757D53FFB0736299EECB0B2","height":513,"level":"info","module":"state","txs":0} {"_msg":"Starting rpc client","level":"info"} {"_msg":"Starting application REST service (chain-id: \"mesg-dev-chain\")...","level":"info","module":"rest-server"} {"_msg":"Starting RPC HTTP server on [::]:1317","level":"info","module":"rest-server"} {"_msg":"Starting orchestrator","level":"info"} {"_msg":"Starting gRPC server","level":"info"} {"_msg":"Server listens on [::]:50052","level":"info","module":"grpc"} {"_msg":"Executed block","height":514,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"0DD2398BC0EC1AB37A7AF3EB9D9F5A51B2A3360311092C2359E69835AA875DCC","height":514,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":515,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"58BA949DE2CCA3FA3107DE006BD22B98A223B019F1E169D953B644AF00C21410","height":515,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":516,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"83A804A433427F1CB96161EBD08AEFDBC28CF71FAEA3B978C7ED4BF6B5977D50","height":516,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":517,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"0B7353DD8FE4227B72559103FB5A378042645530DE1EDAFA25E1DA03F91F3849","height":517,"level":"info","module":"state","txs":0} {"_msg":"Executed block","height":518,"invalidTxs":0,"level":"info","module":"state","validTxs":0} {"_msg":"Committed state","appHash":"0854F12AE039E02C7C62AB1A7E8B983E755C360D6209BFFB1C2159E063A65176","height":518,"level":"info","module":"state","txs":0} {"_msg":"executed process transition","eventHash":"6bzdDdAjGapQAicvXME5ynBSHWCQLKRXWShvqG9AH8yv","from":"n0","input":"{\"fields\":{\"msg\":{\"Kind\":{\"string_value\":\"foo_event\"}},\"timestamp\":{\"Kind\":{\"number_value\":1589974404}}}}","level":"info","module":"orchestrator","processHash":"6ff6S7LdzWL1dR6zXtdcqwmemjgFXvpjG4ca8pFuncEX","to":"n1","type":"event"}I couldn't find a way to properly implement
MarshalJSONfunction on protobuf struct without breaking the encoding somewhere else. So they are encoded in JSON-string (otherwise it's encoded in aCompactTextStringthat's even worst):{ "_msg": "executed process transition", "eventHash": "6bzdDdAjGapQAicvXME5ynBSHWCQLKRXWShvqG9AH8yv", "from": "n0", "input": "{\"fields\":{\"msg\":{\"Kind\":{\"string_value\":\"foo_event\"}},\"timestamp\":{\"Kind\":{\"number_value\":1589974404}}}}", "level": "info", "module": "orchestrator", "processHash": "6ff6S7LdzWL1dR6zXtdcqwmemjgFXvpjG4ca8pFuncEX", "to": "n1", "type": "event" }