Improve log in cmd service dev #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
previously approved these changes
Aug 30, 2018
krhubert
reviewed
Aug 30, 2018
cmd/service/dev.go
Outdated
| } | ||
| } | ||
|
|
||
| func formatJSON(data string) string { |
There was a problem hiding this comment.
Move to utils?
Missing docs.
s/formatJSON/colorJSON/ ?
There was a problem hiding this comment.
In which utils your suggest to move it? service/utils? cmd/utils?
|
Pls use logrus. Let's keep only one logging package in the app. |
|
We will continue to use logrus for log in the core/daemon. I switch back to log in the command I remember we agree that CLI (cmds) will not use logrus. |
|
Modification done, @mesg-foundation/core please review |
ilgooz
approved these changes
Sep 1, 2018
antho1404
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In command service dev: