-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple core runnable #478
Conversation
This close #457 |
To do:
Done in commit 462108b |
…cific core base on its name
…mesg-foundation/core into feature/core-name-configuration
This pull request has been mentioned on MESG Community. There might be relevant details there: |
config/config.go
Outdated
@@ -37,8 +37,9 @@ type Config struct { | |||
} | |||
|
|||
Core struct { | |||
Image string | |||
Path string | |||
Image string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this part, why do we need name and rootpath?
What rootpath means - consider remaining it to ConfigPath as this is what you mean right?
Also when the path is explicit given the app shouldn't create new directories (.mesg
) under it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of that is to have the database stored in it's own directory so the root path is the one that will store all the different "core" instances
Right now we have
~/.mesg/
├── database
And this change to
~/.mesg/
├── mesg-core/
| ├── database
Like that we can now run different instances of the core with their own separated database
~/.mesg/
├── mesg-core1/
| ├── database
├── mesg-core2/
| ├── database
...
The RootPath
is the one to store the .mesg
and the CorePath()
is the one to use to know where to write. This one returns the RootPath + Name
.
ConfigPath
is a bit ambiguous because it's the config of the core so this should be the ~/.mesg/mesg-core
Also when the path is explicit given the app shouldn't create new directories (.mesg) under it.
Why shouldn't we do that ? The goal of this property is to be the "namespace" for the folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion on discord and the feedbacks of @krhubert we can remove the RootPath
and just keep a CorePath
that is customizable by the user and so we would just have the MESG_CORE_PATH
to edit more
…mesg-foundation/core into feature/core-name-configuration
@mesg-foundation/core ready to review again, I added the |
We can now sandbox the core in it's own context, the
.mesg
folder contains now a folder for each core based on the name. The core now has all the docker configurations (service, container, network) based on its name and we can now so run multiple core with some env variable.and access with the cli
Please merge #477 before