This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
Types generation #112
Merged
Types generation #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2019
Merged
NicolasMahe
reviewed
Jul 25, 2019
Co-Authored-By: Nicolas Mahé <nicolas@mesg.com>
NicolasMahe
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate types using https://github.com/protobufjs/protobuf.js.
It generates a js file of the definition and then based on the JSDoc of this file is creates the TS types.
That's a bit overkill but we can generate the types for the API and the resources.
All the files in the
api/typedefdirectory are the one auto-generated.