Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help-wanted section in README. #18

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

jesuslerma
Copy link
Contributor

This PR is related to meshery/meshery#492

Signed-off-by: jesuslerma <shuyojl@gmail.com>
@jesuslerma
Copy link
Contributor Author

Hi @leecalcote it looks that the issue is related with the current go code. I think the best is to fix each Check & Review code and then update this PR.

@leecalcote
Copy link
Member

@jesuslerma good highlight regarding the linting issues found in the code review check. Nice work on capturing this in issue #19. @gunjanmimo or @ashiscs might find #19 of interest.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. This looks good, @jesuslerma.

@leecalcote leecalcote merged commit 0e1ca86 into meshery:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants