Updated Readme Link #34
Conversation
Added a "community member form" link in the community section of the readme section
There was a problem hiding this comment.
You did not "To" at the beginning of the senstence.
And please remove the community drive link, we no longer need that there.
and replace the community member link to this "https://layer5.io/newcomer/"
|
ok. I will do it |
Added a community member link in Readme community section
There was a problem hiding this comment.
Looks great, although, You must have missed signing off the commit.
Try this https://github.com/layer5io/meshery-app-mesh/pull/34/checks?check_run_id=2529877789, and we will be good to go.
|
@sanjana-98 here is how to sign off a commit: |
|
@Anita-ihuman Am sorry am not able to modify commit message in gitbash. can i do it here itself in github.because even the link change I did it in github itself |
|
Hello Santana, well in this organization, it is mandatory to sign off
every commit. Please look through the general contribution work flow
https://github.com/layer5io/meshery/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin
On Sat, 8 May 2021 at 11:37 AM, sanjana-98 ***@***.***> wrote:
@Anita-ihuman <https://github.com/Anita-ihuman> Am sorry am not able to
modify commit message in gitbash. can i do it here itself in github.because
even the link change I did it in github itself
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO36UE25YKEDSBNVMYSHOOTTMUH57ANCNFSM44KKWPMA>
.
--
Anita Ihuman
|
|
Ok |
|
Thank you, @sanjana-98 and @Anita-ihuman 🙂 |
Signed-off-by: sanjana-98 sanjana.balaji1@gmail.com
Description
This PR fixes #33
Notes for Reviewers
Added a new link in the Community section in the README which says "Access the Community Drive" to "Access Community Drive, fill Community Member Form"
Signed Commits