Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking of App-Mesh adapter #41

Merged
merged 13 commits into from
Oct 13, 2021
Merged

Reworking of App-Mesh adapter #41

merged 13 commits into from
Oct 13, 2021

Conversation

Shreyas220
Copy link
Member

@Shreyas220 Shreyas220 commented Aug 31, 2021

Description
Made some changes according to the design spec for adapter

This PR fixes #40

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
Copy link
Member Author

Shreyas220 commented Sep 4, 2021

thanks for the review @DelusionalOptimist
now we are able to do the following operation

  • installing app-mesh
  • installing sample application

image

will get the other operation working soon as well
excited to get this adapter up and running 😄😄

@sayantan1413 can we get that workflows up before merging this PR

@leecalcote
Copy link
Member

Wow! That screenshot is exciting!

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
Copy link
Member Author

Shreyas220 commented Sep 5, 2021

when i run the smi conformance operation i get this error
@DelusionalOptimist @Utkarsh-pro
image

ERRO[2021-09-05T14:13:13+05:30] rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp [::1]:31944: connect: connection refused" app=app-mesh-adapter code=1011 probable-cause= severity=2 short-description="Error running SMI conformance test" suggested-remediation=

@DelusionalOptimist
Copy link
Contributor

@Shreyas220 you need a load-balancer to expose SMI conformance tool. There should be a guide somewhere to do so based on your k8s cluster.

@Shreyas220
Copy link
Member Author

Shreyas220 commented Sep 9, 2021

@DelusionalOptimist @Utkarsh-pro looks like we are able to do all the operation but the the app-mes-controller image is imagepullbackoff
so any ideas on how should we proceed ?

@DelusionalOptimist
Copy link
Contributor

Some good work going on by @Shreyas220. : )
After a little debugging session and some changes in this PR, the adapter and app-mesh controller using the adapter installs well in-cluster (EKS). No IAM issues 👍
2021-10-07_15-04

Action items now:

  • See what app-mesh components, other than the controller are needed to do a usable app-mesh deployment.
  • Try deploying sample apps and make sure services are being meshed.
  • Show the adapter in Meshery UI.

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@DelusionalOptimist DelusionalOptimist self-assigned this Oct 13, 2021
@Shreyas220 Shreyas220 removed the pr/do-not-merge PRs not ready to be merged label Oct 13, 2021
@leecalcote leecalcote merged commit 8909739 into meshery:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter not working
3 participants