D2IQ-100548: add missing .aws/config file mount - main #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatz
changed the title
supershal
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
.aws/configis being ignored by KIB. This is an issue especially when custom config likeaws configure ssois being used or special profiles.Due to the D2iQ tooling relied completely on .aws/credentials this was never noticed before.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
.aws/configis an important part of SDK config. We completely forgot about itDoes this PR introduce a user-facing change?:
No change expected. If the file is not provided or existing its should be ignored