You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a requirement we can do in the future, but the idea of this is to avoid overwriting those Find*.cmake files so we can also debug and maintain those CMake files. For example, right now FindNodeJS.cmake has bugs in order to find properly the node libraries once it is built.
Maybe the Python or Ruby patches can be maintained because we do not maintain them.
I am not sure if this should be the best approach but it's an idea that I have had in order to keep debugging the CMake files we maintain in the long term. We can do this at the end (once all languages are supported) because it is just an improvement.
It is also problematic in the sense that those script files have been used for developers to configure or install the project dependencies (in Linux at least for now), and if we do the patching.. we break the repository files itself, and it's a not desired behavior.
Also this approach comes from the distributable, which it makes sense because we are just packaging it and there's no need of maintaining those files, and also they are usually placed on non-standard places (usually in the same folder where everything is built), but this is not the same in the developer environment.
The text was updated successfully, but these errors were encountered:
Honestly I don't like patching these cmake files, it's ok in dist version but while developing if we could just simply set some default nodejs location or install nodejs ourselves in the runtimes dir even if it's present and override the env vars
🚀 Feature
https://github.com/metacall/core/blob/develop/tools/metacall-environment.ps1
This is a requirement we can do in the future, but the idea of this is to avoid overwriting those Find*.cmake files so we can also debug and maintain those CMake files. For example, right now FindNodeJS.cmake has bugs in order to find properly the node libraries once it is built.
Maybe the Python or Ruby patches can be maintained because we do not maintain them.
I am not sure if this should be the best approach but it's an idea that I have had in order to keep debugging the CMake files we maintain in the long term. We can do this at the end (once all languages are supported) because it is just an improvement.
It is also problematic in the sense that those script files have been used for developers to configure or install the project dependencies (in Linux at least for now), and if we do the patching.. we break the repository files itself, and it's a not desired behavior.
Also this approach comes from the distributable, which it makes sense because we are just packaging it and there's no need of maintaining those files, and also they are usually placed on non-standard places (usually in the same folder where everything is built), but this is not the same in the developer environment.
The text was updated successfully, but these errors were encountered: