Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the patching of Find*.cmake files in Windows CI #373

Closed
viferga opened this issue Jan 18, 2023 · 2 comments · Fixed by #394
Closed

Remove the patching of Find*.cmake files in Windows CI #373

viferga opened this issue Jan 18, 2023 · 2 comments · Fixed by #394
Assignees
Labels
devops Related to DevOps infrastructure of the Core enhancement New feature or request

Comments

@viferga
Copy link
Member

viferga commented Jan 18, 2023

🚀 Feature

https://github.com/metacall/core/blob/develop/tools/metacall-environment.ps1

This is a requirement we can do in the future, but the idea of this is to avoid overwriting those Find*.cmake files so we can also debug and maintain those CMake files. For example, right now FindNodeJS.cmake has bugs in order to find properly the node libraries once it is built.

Maybe the Python or Ruby patches can be maintained because we do not maintain them.

I am not sure if this should be the best approach but it's an idea that I have had in order to keep debugging the CMake files we maintain in the long term. We can do this at the end (once all languages are supported) because it is just an improvement.

It is also problematic in the sense that those script files have been used for developers to configure or install the project dependencies (in Linux at least for now), and if we do the patching.. we break the repository files itself, and it's a not desired behavior.

Also this approach comes from the distributable, which it makes sense because we are just packaging it and there's no need of maintaining those files, and also they are usually placed on non-standard places (usually in the same folder where everything is built), but this is not the same in the developer environment.

@viferga viferga self-assigned this Jan 18, 2023
@viferga viferga added devops Related to DevOps infrastructure of the Core enhancement New feature or request labels Jan 18, 2023
@viferga
Copy link
Member Author

viferga commented Jan 18, 2023

@pkspyder007 what do you think about this?

@pkspyder007
Copy link
Contributor

Honestly I don't like patching these cmake files, it's ok in dist version but while developing if we could just simply set some default nodejs location or install nodejs ourselves in the runtimes dir even if it's present and override the env vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to DevOps infrastructure of the Core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants