From a1a9c11a4ea1b7564359c9c64c7eb6d2b2d4b094 Mon Sep 17 00:00:00 2001 From: hulxv Date: Fri, 23 Feb 2024 02:57:37 +0200 Subject: [PATCH] fix(build): icu4c v72.x is too old --- cmake/FindNodeJS.cmake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmake/FindNodeJS.cmake b/cmake/FindNodeJS.cmake index 8ff2210fd..ae95d2c16 100644 --- a/cmake/FindNodeJS.cmake +++ b/cmake/FindNodeJS.cmake @@ -498,7 +498,9 @@ if(NOT NodeJS_LIBRARY) set(BUILD_ICU_FLAGS "--without-intl") else() # Select the ICU library depending on the NodeJS version - if("${NodeJS_VERSION_MAJOR}" GREATER_EQUAL "18") + if("${NodeJS_VERSION_MAJOR}" GREATER_EQUAL "20") + set(ICU_URL "https://github.com/unicode-org/icu/releases/download/release-73-1/icu4c-73_1-src.zip") + elseif("${NodeJS_VERSION_MAJOR}" GREATER_EQUAL "18") set(ICU_URL "https://github.com/unicode-org/icu/releases/download/release-72-1/icu4c-72_1-src.zip") elseif("${NodeJS_VERSION_MAJOR}" GREATER_EQUAL "16") set(ICU_URL "https://github.com/unicode-org/icu/releases/download/release-69-1/icu4c-69_1-src.zip")