Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation #14

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

update documentation #14

wants to merge 12 commits into from

Conversation

Dami-18
Copy link
Contributor

@Dami-18 Dami-18 commented Jun 24, 2024

Fixes #11

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heimdall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 10:10am

@Dami-18
Copy link
Contributor Author

Dami-18 commented Jun 24, 2024

@chirag-ghosh @rohan-b-84 review please

@rohan-b-84
Copy link
Contributor

Can you also update the frontend readme file as well ?
Right now you've mentioned to run npm run dev in base directory, when it should be inside ./frontend

Also, suggest using pnpm instead of npm

Documenting doesn't only mean updating docs on how to run the server, you'll have to mention what the application does, and how its supposed to be used

@Dami-18 Dami-18 changed the title update documentation update documentation and show otp cooldown message Jun 24, 2024
@proffapt proffapt force-pushed the master branch 4 times, most recently from 8827eeb to d9291f3 Compare June 26, 2024 09:16
@rohan-b-84
Copy link
Contributor

@Dami-18 have you added a way to display cooldown timer for resend OTP ?
I don't see those changes anywhere

@Dami-18
Copy link
Contributor Author

Dami-18 commented Jun 27, 2024

@Dami-18 have you added a way to display cooldown timer for resend OTP ? I don't see those changes anywhere

I haven't added any timer. Only displaying the message that please wait for 60s as it was already set in the backend

@Dami-18
Copy link
Contributor Author

Dami-18 commented Jun 27, 2024

Should I add timer also?

Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always recommended to have separation of concerns in PRs as well. Solving two separate issues in a PR doesn't help in better resolution. Create two separate PRs for each issue.

@proffapt
Copy link
Member

proffapt commented Jun 28, 2024

Also this is what we have planned as a solution to this:

  • use requests the OTP
  • in frontend a time starts in content of the request otp button
  • the button is disabled till the timer hits 0
  • a text appears resend otp and the button is now clickable

@Dami-18 Dami-18 changed the title update documentation and show otp cooldown message update documentation Jun 28, 2024
@Dami-18
Copy link
Contributor Author

Dami-18 commented Jun 30, 2024

Why am I getting "No JWT session token found" in /validate-jwt even after I verified using otp?

@proffapt proffapt force-pushed the master branch 6 times, most recently from f366656 to df885ae Compare July 2, 2024 09:54
@chirag-ghosh
Copy link
Member

The cookie we are using is a secure cookie. It is only sent by the browser for HTTPS requests. Since you are using localhost which is HTTP, the browser is not sending the cookie in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation
4 participants