Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the user that there is still a cooldown for OTP #13

Closed
Tracked by #10
proffapt opened this issue Jun 17, 2024 · 16 comments · Fixed by #18
Closed
Tracked by #10

Show the user that there is still a cooldown for OTP #13

proffapt opened this issue Jun 17, 2024 · 16 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@proffapt
Copy link
Member

proffapt commented Jun 17, 2024

  • User requests the OTP
  • In frontend a timer starts in-place of the content of request otp button
  • The button is disabled till the timer hits 0
  • Button content changes to resend otp and the button is now clickable
@proffapt proffapt added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 17, 2024
@Dami-18
Copy link
Contributor

Dami-18 commented Jun 21, 2024

What is the issue exactly? Can I work on it?

@proffapt
Copy link
Member Author

So the issue is:

If you have requested for OTP, you can't request for another till 1 minute cooldown timeout. This is implemented in backend but the user won't know from frontend and when they try to request it again within that timeframe they receive this generic error message "Failed to send the OTP".

Sure go ahead and just present the actual error received from the backend.

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 22, 2024

Facing issues in setup. Heimdall server is running on port 3333 but when I enter my mail Id and click generate otp, it is not able to find credentials.json file

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 22, 2024

So not getting otp even for the first time

@proffapt
Copy link
Member Author

have you configured Gmail api credentials?

@proffapt
Copy link
Member Author

The documentation is not updated. cc @rohan-b-84 @chirag-ghosh

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 22, 2024

have you configured Gmail api credentials?

How do I do that?

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 22, 2024

But why is it working without any configuration on the hosted site?

@rohan-b-84
Copy link
Contributor

@proffapt updating documentation itself is an issue #11

@Dami-18 to get credentials.json file
first create the OAuth consent screen and then create OAuth client ID credentials and save the downloaded json as credentials.json in the project's root folder.

If you get through this, can you also take #11 as well ?

@chirag-ghosh
Copy link
Member

@Dami-18 it is working on the hosted site because it has those files. We add them to the server when we set it up. A better documentation will make things clear.

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 23, 2024

@proffapt updating documentation itself is an issue #11

@Dami-18 to get credentials.json file first create the OAuth consent screen and then create OAuth client ID credentials and save the downloaded json as credentials.json in the project's root folder.

If you get through this, can you also take #11 as well ?

Ok once I am able to successfully run the dev server, I will update documentation too

@proffapt
Copy link
Member Author

There's an issue corresponding to documentation #11

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 23, 2024

I got the credentials.json file but after running server, when it says go to following link and enter the authentication code, it always says refused to connect or invalid request after clicking on the link. I tried changing redirect urls and checked network also but still facing same error. What could be the possible issue?

@chirag-ghosh
Copy link
Member

When it redirects, the url will redirect to localhost and will contain the code in the url parameters itself. ?code=something ig. That something is the code you need to paste in the terminal.
I know this is a really janky way to do but once that token.json is created, It'll be valid for 6months so I didn't care about it much

@Dami-18
Copy link
Contributor

Dami-18 commented Jun 24, 2024

Also @proffapt new version of erp-login package expected to release when? We need to complete gyfe and gyft before subject registration

@proffapt
Copy link
Member Author

Also @proffapt new version of erp-login package expected to release when? We need to complete gyfe and gyft before subject registration

https://metakgp.slack.com/archives/C05KTAL5ARM/p1719258932859839

This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants