Fix mount for node-driver-registrar #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently --kubelet-registration-path parameter of node-driver-registrar container from csi-driver-lvm-plugin daemonSet points to the directory which is not mounted. Found this out when tried to run all csi-driver-lvm containers with readOnlyRootFilesystem securityContext set to "true".
This was referenced May 1, 2023
|
I'm not sure I understand this correctly as those two sockets provided for node-driver-registrar are actually the same socket. |
|
Hello |
|
Sorry, it took this long to get a reaction from our side. We discussed this in the team and honestly we do not fully understand how it works. I assume it's just fine to merge it, so I will before having you to wait for another year. |
Gerrit91
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently --kubelet-registration-path parameter of node-driver-registrar container from csi-driver-lvm-plugin daemonSet points to the directory which is not mounted.
Found this out when tried to run all csi-driver-lvm containers with readOnlyRootFilesystem securityContext set to "true".