Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.6] 🌱 Remove capm3_e2e dependency from bmo E2E #1682

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1681

/assign mquhuy

Signed-off-by: Huy Mai <huy.mai@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2024
@tuminoid
Copy link
Member

/hold

CI is not set up for the branch yet

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
let's merge this one.

@metal3-io-bot
Copy link
Contributor Author

@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
let's merge this one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

/test metal3-centos-e2e-integration-test-release-1-7 metal3-bmo-e2e-test-pull

@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

/unhold
CI should be fine now, let's check the tests.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

CI fix in metal3-io/project-infra#732 needed

@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

/test metal3-centos-e2e-integration-test-release-1-7 metal3-bmo-e2e-test-pull

@mquhuy mquhuy requested a review from adilGhaffarDev May 7, 2024 05:23
@mquhuy
Copy link
Member

mquhuy commented May 10, 2024

/cc @tuminoid @kashifest @lentzi90
CI tests are fine now. We should merge this

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor Author

@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adilGhaffarDev
Copy link
Member

@Rozzii this needs lgtm. I have reviewed LGTM from my side.

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@metal3-io-bot metal3-io-bot merged commit 623b807 into metal3-io:release-0.6 May 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants