🐛 Pinning ironic image release-24.1 where it was missed

[adilGhaffarDev]

What this PR does / why we need it:
In PR: #1679 ironic image was not pinned everywhere. This PR is fixing it.

[adilGhaffarDev]

/cc @dtantsur @elfosardo please check. let me know if I missed anywhere.

[kashifest]

/lgtm

[elfosardo]

/approve

[tuminoid]

/test metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-release-1-7

[tuminoid]

Needs CI fix in metal3-io/project-infra#732 to merge

[tuminoid]

/test metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-release-1-7

[tuminoid]

There is something fishy with CI still. Running 1.7 test keyword, it is getting 1.6 CAPM3:

[2024-05-06T11:32:48.872Z] /home/metal3ci/metal3/test/e2e/e2e_suite_test.go:102
[2024-05-06T11:32:48.872Z] 
[2024-05-06T11:32:48.872Z]   [FAILED] Failed to generate the manifest for "infrastructure-metal3" / "v1.6.1"

@Sunnatillo @mboukhalfa @adilGhaffarDev ?

[kashifest]

I thi

There is something fishy with CI still. Running 1.7 test keyword, it is getting 1.6 CAPM3:

[2024-05-06T11:32:48.872Z] /home/metal3ci/metal3/test/e2e/e2e_suite_test.go:102
[2024-05-06T11:32:48.872Z] 
[2024-05-06T11:32:48.872Z]   [FAILED] Failed to generate the manifest for "infrastructure-metal3" / "v1.6.1"

@Sunnatillo @mboukhalfa @adilGhaffarDev ?

I think CAPM3 1.7 e2e tests wont work properly until metal3-io/cluster-api-provider-metal3#1634 this goes in, correct me @adilGhaffarDev

[adilGhaffarDev]

I think CAPM3 1.7 e2e tests wont work properly until metal3-io/cluster-api-provider-metal3#1634 this goes in, correct me @adilGhaffarDev

it seems like a flake because URL it is complaining about is working fine. https://github.com/metal3-io/cluster-api-provider-metal3/releases/download/v1.6.1/infrastructure-components.yaml

lets run it again

[adilGhaffarDev]

/test metal3-centos-e2e-integration-test-release-1-7

[kashifest]

I think CAPM3 1.7 e2e tests wont work properly until metal3-io/cluster-api-provider-metal3#1634 this goes in, correct me @adilGhaffarDev

it seems like a flake because URL it is complaining about is working fine. https://github.com/metal3-io/cluster-api-provider-metal3/releases/download/v1.6.1/infrastructure-components.yaml

lets run it again

point is why should it run that version for a 1.7 test

[adilGhaffarDev]

point is why should it run that version for a 1.7 test

yes, we need to merge that PR.

regarding failure e2e framework downloads manifests for all the versions that we add in our config(https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/test/e2e/config/e2e_conf.yaml), it failed while trying to download one of the manifests, which is before the start of any test.

[kashifest]

regarding failure e2e framework downloads manifests for all the versions that we add in our config(https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/test/e2e/config/e2e_conf.yaml), it failed while trying to download one of the manifests, which is before the start of any test.

ok thats very strange, why should it download the manifest for a version which is not being tested here, is this a CAPI e2e framework feature or I should say limitation ?

[adilGhaffarDev]

ok thats very strange, why should it download the manifest for a version which is not being tested here, is this a CAPI e2e framework feature or I should say limitation ?

yes, it's part of CAPI e2e framework, we use these manifests in upgrade tests.

[adilGhaffarDev]

@kashifest can you approve this ? @elfosardo has already approved it.

[lentzi90]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment