Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump kustomize version from v4 to v5 #1718

Merged
merged 1 commit into from
Aug 7, 2024
Merged

🌱 Bump kustomize version from v4 to v5 #1718

merged 1 commit into from
Aug 7, 2024

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented May 3, 2024 •
edited
Loading

What this PR does / why we need it:
Bump Kustomize version

Which issue(s) this PR fixes:

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
@peppi-lotta peppi-lotta changed the title Bump kustomize version from v4 to v5 🌱 Bump kustomize version from v4 to v5 May 3, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/bump-kustomize-version branch from 5c5220f to fd5588e Compare May 3, 2024 07:05
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@peppi-lotta
Copy link
Member Author

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 3, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

Test failure unrelated, needs to be fixed elsewhere first.

@tuminoid tuminoid mentioned this pull request May 6, 2024
Merged
@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/bump-kustomize-version branch from fd5588e to 405b91f Compare May 7, 2024 09:57
@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-ubuntu-e2e-integration-test-main

@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@peppi-lotta peppi-lotta mentioned this pull request May 13, 2024
Merged
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

/retest
CI could be better now.

@tuminoid
Copy link
Member

Seems there is an actual issue with the PR. Kustomize complained and caused a failure.

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/bump-kustomize-version branch from 405b91f to 254e6c5 Compare May 30, 2024 07:59
@peppi-lotta
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@peppi-lotta
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@peppi-lotta: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-centos-main

@mquhuy
Copy link
Member

mquhuy commented Jun 26, 2024

/retest

@Rozzii Rozzii added this to the BMO - v0.7.0 milestone Jun 28, 2024
@mquhuy
Copy link
Member

mquhuy commented Jul 1, 2024

/test metal3-centos-e2e-integration-test-main

@Rozzii Rozzii removed this from the BMO - v0.6.2 milestone Jul 3, 2024
@mquhuy mquhuy force-pushed the peppi-lotta/bump-kustomize-version branch from 254e6c5 to be5b6ee Compare July 9, 2024 12:36
@mquhuy
Copy link
Member

mquhuy commented Jul 9, 2024

/retest

@mquhuy
Copy link
Member

mquhuy commented Jul 9, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy mquhuy force-pushed the peppi-lotta/bump-kustomize-version branch from be5b6ee to d9fa6d5 Compare July 9, 2024 16:08
@mquhuy
Copy link
Member

mquhuy commented Jul 9, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-dev-env-integration-test-centos-main

Rozzii
Rozzii reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@mquhuy
Copy link
Member

mquhuy commented Jul 10, 2024

/cc @dtantsur @honza @zaneb

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 6, 2024
@mquhuy
Copy link
Member

mquhuy commented Aug 7, 2024

/cc @kashifest @tuminoid

@mquhuy mquhuy requested a review from Rozzii August 7, 2024 09:34
@mquhuy
Copy link
Member

mquhuy commented Aug 7, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-dev-env-integration-test-centos-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Aug 7, 2024 •
edited
Loading

@peppi-lotta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main 405b91f link false /test metal3-ubuntu-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@peppi-lotta @mquhuy
Bump kustomize version from v4 to v5
6da5d87 
Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>
@mquhuy mquhuy force-pushed the peppi-lotta/bump-kustomize-version branch from cef89b7 to 6da5d87 Compare August 7, 2024 09:35
@mquhuy
Copy link
Member

mquhuy commented Aug 7, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-dev-env-integration-test-centos-main

tuminoid
tuminoid reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@metal3-io-bot metal3-io-bot merged commit b814056 into metal3-io:main Aug 7, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/bump-kustomize-version branch August 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

@kashifest kashifest Awaiting requested review from kashifest

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
BMO - v0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @tuminoid @metal3-io-bot @mquhuy @kashifest @Rozzii