Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump sigs.k8s.io/kustomize/kyaml from 0.17.2 to 0.18.0 in /hack/tools #1976

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 29, 2024

Bumps sigs.k8s.io/kustomize/kyaml from 0.17.2 to 0.18.0.

Release notes

Sourced from sigs.k8s.io/kustomize/kyaml's releases.

api/v0.17.3

chore

#5506: fix some comments #5693: fix: always show accumulation errors #5699: chore: add deprecation comment to commonLabels #5698: fix(namereference): add configuration for new admission API

Dependencies

#5734: Update kyaml to v0.17.2

Commits
  • 2cd9a2e Merge pull request #5768 from dims/remove-starlark-support
  • d32eacf Remove starlark support
  • 88f19bf Merge pull request #5763 from koba1t/update_go_1.22.7
  • a3c0b4a disable for a step to skip test when that is docs PR
  • b67ce5b go work sync && ./hack/doGoMod.sh tidy
  • 5ba8523 update go 1.22.7
  • 4034e36 Add --helm-debug Flag to Kustomize for Enhanced Helm Debugging (#5751)
  • c3872ce Merge pull request #5745 from isarns/master
  • d35d21c Merge pull request #5760 from Kavinjsir/patch-docs
  • a5f43ec style: linting
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 29, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 29, 2024
@tuminoid
Copy link
Member

/retest
New basic-checks image is in place now.

@tuminoid
Copy link
Member

/hold
Seems there is compatibility issue bumping this minor.

https://prow.apps.test.metal3.io/view/s3/prow-logs/pr-logs/pull/metal3-io_baremetal-operator/1976/generate/1840726827983704064

cd apis; /home/prow/go/src/github.com/metal3-io/baremetal-operator/tools/bin/controller-gen object:headerFile="../hack/boilerplate.go.txt" paths="./..."
tools/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
cd apis; /home/prow/go/src/github.com/metal3-io/baremetal-operator/tools/bin/controller-gen "crd:allowDangerousTypes=true,crdVersions=v1" rbac:roleName=manager-role webhook paths="./..." output:webhook:dir=../config/base/webhook/ output:crd:artifacts:config=../config/base/crds/bases
tools/bin/controller-gen rbac:roleName=manager-role paths="./..." output:rbac:artifacts:config=config/base/rbac
cd hack/tools; go build -o /home/prow/go/src/github.com/metal3-io/baremetal-operator/tools/bin/kustomize sigs.k8s.io/kustomize/kustomize/v5
go: downloading sigs.k8s.io/kustomize/kustomize/v5 v5.4.3
go: downloading sigs.k8s.io/kustomize/cmd/config v0.14.2
go: downloading github.com/sergi/go-diff v1.2.0
# sigs.k8s.io/kustomize/cmd/config/internal/commands
/home/prow/go/pkg/mod/sigs.k8s.io/kustomize/cmd/config@v0.14.2/internal/commands/run-fns.go:349:3: unknown field EnableStarlark in struct literal of type runfn.RunFns
# sigs.k8s.io/kustomize/api/internal/plugins/fnplugin
/home/prow/go/pkg/mod/sigs.k8s.io/kustomize/api@v0.17.3/internal/plugins/fnplugin/fnplugin.go:80:4: unknown field EnableStarlark in struct literal of type runfn.RunFns
make: *** [Makefile:193: tools/bin/kustomize] Error 1

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
Bumps [sigs.k8s.io/kustomize/kyaml](https://github.com/kubernetes-sigs/kustomize) from 0.17.2 to 0.18.0.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@api/v0.17.2...kyaml/v0.18.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/kyaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kyaml-0.18.0 branch from e6a2ce8 to 480c965 Compare October 7, 2024 23:30
@metal3-io-bot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
generate adaa64a link true /test generate
test adaa64a link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tuminoid
Copy link
Member

tuminoid commented Oct 8, 2024

/assign @kashifest
Same as #1977

@kashifest
Copy link
Member

This is possibly broken because of the fact that kustomize has tagged kyaml v0.18.0 where they have removed the starlark support but they do not have corresponding tags/releases for kustomize/api and kustomize/cmd/config modules which uses it. I have created an issue upstream for this kubernetes-sigs/kustomize#5779

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 13, 2024

Superseded by #1993.

@dependabot dependabot bot closed this Oct 13, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kyaml-0.18.0 branch October 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants