Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for CAPI IPAM contract #941

Open
schrej opened this issue Apr 26, 2023 · 3 comments
Open

Add e2e tests for CAPI IPAM contract #941

schrej opened this issue Apr 26, 2023 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@schrej
Copy link
Member

schrej commented Apr 26, 2023

#769 was merged without e2e tests since I didn't see a clear path to implement them, as there doesn't seem to be a basic "create a cluster" test case.

We've created telekom/cluster-api-ipam-provider-in-cluster (might move to kubernetes-sigs), which serves as a reference implementation and is also suitable for testing. It's essentially a direct replacement for metal3-io/ip-address-manager and also manages pools as resources in the cluster (it does not have feature parity).

CAPV is also working on e2e tests, in case that helps: kubernetes-sigs/cluster-api-provider-vsphere#1667
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Apr 26, 2023
@Rozzii
Copy link
Member

Rozzii commented Apr 26, 2023

/triage accepted
/assign @schrej

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 26, 2023
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2023
@Rozzii
Copy link
Member

Rozzii commented Aug 2, 2023

Would be welcomed I will move this to frozen, no need to always remove the stale
/lifecycle frozen
/help

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 2, 2023
@metal3-io metal3-io deleted a comment from metal3-io-bot Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schrej @Rozzii @metal3-io-bot