🌱 Introduce ReconcileError with Transient and Terminal Error type #787
Conversation
Remove RequeueAfterError(depricated in CAPM3) Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
| @@ -0,0 +1,85 @@ | |||
| /* | |||
There was a problem hiding this comment.
I assume from the license message, that this file and the related test file were copied.
Is there a possibility to find these Error types in some library that we could pull in as a dependency instead of duplicating this code?
If this is not copied but written by you, then my question is that why are you adding the K8s author copyright?
There was a problem hiding this comment.
I know other files have this copyright here, I will start a discussion with the community related to that also.
This PR:
Introduces ReconcileError with Transient and Terminal Error type
Removes RequeueAfterError (as it was depricated in CAPI and CAPM3)
ReconcileError represents an generic error of Reconcile loop. errorType indicates what type of action is required to recover. It can take two values:
a. Transient - Can be recovered , will be requeued after.
b. Terminal - Cannot be recovered, will not be requeued.
When error is not ReconcileError it will be returned to Reconciler.