🐛 improve upper constraints handling #590
Conversation
This commit: - Provides a default value for the UPPER_CONSTRAINT docker file argument - Changes the prepare-image.sh logic to check the actual size of the upper constraint file and not the presence of it. Background of this change is that it has been noticed that on release branches during image building the "pinned" upper constraint file is not picked up rather pulled from upstream OpenStack because of a lack of default argument value during image building. Signed-off-by: Adam Rozman <adam.rozman@est.tech>
metal3-io-bot
added
the
size/XS
|
/cc @tuminoid @elfosardo |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
For reference: this is manual cherry-pick of #584 |
|
/test metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1- |
|
/test metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7 |
|
/retitle 🐛 improve upper constraints handling |
metal3-io-bot
changed the title
|
/retest |
[4.17] OCPBUGS-42692: Include fixes for CVE-2024-5569
|
/retest |
|
/test metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7 |
This commit:
Background of this change is that it has been noticed that on release branches during image building the "pinned" upper constraint file is not picked up rather pulled from upstream OpenStack because of a lack of default argument value during image building.