Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add 'syncpack' and sync dependencies #53

Merged
merged 10 commits into from
Sep 24, 2024
Merged

chore(deps): add 'syncpack' and sync dependencies #53

merged 10 commits into from
Sep 24, 2024

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Sep 23, 2024

This PR adds the syncpack tool to our workflow to ensure that our dependencies are kept in sync inside the monorepo.

Replaces #52

@danroc danroc requested a review from a team as a code owner September 23, 2024 14:38
Copy link

socket-security bot commented Sep 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@effect/schema@0.71.1 None 0 2.6 MB michael.arnaldi
npm/@ledgerhq/hw-app-eth@6.38.1 Transitive: environment, filesystem, network +66 97.4 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@types/jest@29.5.12 None 0 78.7 kB types
npm/@types/node@20.16.1 None 0 2.1 MB types
npm/chalk-template@1.1.0 None 0 13.7 kB sindresorhus
npm/cli-cursor@4.0.0 None 0 4.45 kB sindresorhus
npm/cli-spinners@2.9.2 None 0 32.1 kB sindresorhus
npm/effect@3.6.5 environment 0 18 MB michael.arnaldi
npm/enquirer@2.4.1 environment 0 189 kB jonschlinkert
npm/fast-check@3.22.0 None 0 1.3 MB ndubien
npm/fast-glob@3.3.2 filesystem 0 96.7 kB mrmlnc
npm/is-interactive@2.0.0 None 0 4.73 kB sindresorhus
npm/is-unicode-supported@2.1.0 None 0 3.96 kB sindresorhus
npm/log-symbols@6.0.0 None 0 4.25 kB sindresorhus
npm/ora@8.0.1 environment 0 26.8 kB sindresorhus
npm/read-yaml-file@2.1.0 filesystem 0 3.34 kB zkochan
npm/restore-cursor@4.0.0 None 0 3.23 kB sindresorhus
npm/stdin-discarder@0.2.2 None 0 4.04 kB sindresorhus
npm/syncpack@13.0.0 None 0 285 kB fold_left
npm/tightrope@0.2.0 None 0 288 kB fold_left
npm/ts-toolbelt@9.6.0 None 0 248 kB pirix-gh

🚮 Removed packages: npm/@inquirer/confirm@0.0.14-alpha.0, npm/@inquirer/core@0.0.15-alpha.0, npm/@inquirer/input@0.0.15-alpha.0, npm/@jest/console@28.1.3, npm/@jest/core@28.1.3, npm/@jest/environment@28.1.3, npm/@jest/expect-utils@28.1.3, npm/@jest/expect@28.1.3, npm/@jest/fake-timers@28.1.3, npm/@jest/globals@28.1.3, npm/@jest/reporters@28.1.3, npm/@jest/schemas@28.1.3, npm/@jest/source-map@28.1.2, npm/@jest/test-result@28.1.3, npm/@jest/test-sequencer@28.1.3, npm/@jest/transform@28.1.3, npm/@jest/types@28.1.3, npm/@ledgerhq/hw-app-eth@6.26.1, npm/@sinclair/typebox@0.24.28, npm/@sinonjs/commons@1.8.6, npm/@sinonjs/fake-timers@9.1.2, npm/@types/jest@28.1.7, npm/@types/node@16.18.108, npm/@types/node@17.0.45, npm/@types/node@18.19.50, npm/@types/node@20.16.6, npm/@types/prettier@2.4.4, npm/babel-jest@28.1.3, npm/babel-plugin-jest-hoist@28.1.3, npm/babel-preset-jest@28.1.3, npm/cli-spinners@2.6.1, npm/cli-width@3.0.0, npm/commander@9.3.0, npm/dedent@0.7.0, npm/diff-sequences@28.1.1, npm/emittery@0.10.2, npm/expect@28.1.3, npm/fast-glob@3.2.12, npm/istanbul-lib-instrument@5.1.0, npm/jest-changed-files@28.1.3, npm/jest-circus@28.1.3, npm/jest-cli@28.1.3, npm/jest-config@28.1.3, npm/jest-diff@28.1.3, npm/jest-docblock@28.1.1, npm/jest-each@28.1.3, npm/jest-environment-node@28.1.3, npm/jest-get-type@28.0.2, npm/jest-haste-map@28.1.3, npm/jest-it-up@2.2.0, npm/jest-leak-detector@28.1.3, npm/jest-matcher-utils@28.1.3, npm/jest-message-util@28.1.3, npm/jest-mock@28.1.3, npm/jest-regex-util@28.0.2, npm/jest-resolve-dependencies@28.1.3, npm/jest-resolve@28.1.3, npm/jest-runner@28.1.3, npm/jest-runtime@28.1.3, npm/jest-snapshot@28.1.3, npm/jest-util@28.1.3, npm/jest-validate@28.1.3, npm/jest-watcher@28.1.3, npm/jest-worker@28.1.3, npm/jest@28.1.3, npm/mute-stream@0.0.8, npm/pretty-format@28.1.3, npm/resolve.exports@1.1.0, npm/rimraf@3.0.2, npm/run-async@2.4.1, npm/shiki@0.11.1, npm/supports-hyperlinks@2.1.0, npm/terminal-link@2.1.1, npm/ts-jest@28.0.8, npm/typedoc@0.23.15, npm/vscode-textmate@6.0.0

View full report↗︎

Copy link

socket-security bot commented Sep 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ethersproject/providers@5.7.2, npm/axios@1.7.3, npm/bech32@1.1.4, npm/supports-hyperlinks@2.3.0, npm/ws@7.4.6

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@danroc
Copy link
Contributor Author

danroc commented Sep 24, 2024

@SocketSecurity ignore npm/ws@7.4.6

False positive, there is a resolution for it:

"ws@7.4.6": "^7.5.10"

@danroc
Copy link
Contributor Author

danroc commented Sep 24, 2024

@SocketSecurity ignore npm/axios@1.7.3

False positive, there is a resolution for it:

"axios@1.7.3": "^1.7.7",

@danroc
Copy link
Contributor Author

danroc commented Sep 24, 2024

@SocketSecurity ignore npm/supports-hyperlinks@2.3.0

Both authors are still listed on the projects page on NPM.

@danroc
Copy link
Contributor Author

danroc commented Sep 24, 2024

@SocketSecurity ignore npm/bech32@1.1.4

After checking the project's page on NPM and GitHub, it seems that both authors are contributors.

@danroc
Copy link
Contributor Author

danroc commented Sep 24, 2024

@SocketSecurity ignore npm/@ethersproject/providers@5.7.2

It's an expected capability for a provider.

@ccharly ccharly added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 7233c0c Sep 24, 2024
23 checks passed
@ccharly ccharly deleted the sync-deps branch September 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants