(ISO 13584-20) Boilerplates in "Terms and definitions" render as NOTEs

[manuelfuenmayor]

In relation to https://github.com/metanorma/iso-10303/pull/419

Description of the issue

This:

== Terms and definitions

[.boilerplate]
--
For the purposes of this part of ISO 13584, the following terms and definitions apply.
--

=== Terms and definitions from ISO 10303-11

[.boilerplate]
--
For the purposes of this part of ISO 13584, the following terms and definitions given in
ISO 10303-11:1994 (which are repeated below for convenience) apply.
--

renders as

(Also, note that sub-heading 3.1 showcase a clause-term format.)

To replicate

Execute:

1. git remote update
2. git checkout 13584-corrections
3. bundle exec metanorma -t iso -x html documents/iso-13584-20/document.adoc

[opoudjis]

Right, so the note header needs to be skipped not just for initial boiler plate in terms sections, but for all such boiler plate. This should be a one-liner.

I will likely get to it tonight at some stage, but in general, I'm not going to be available much the next 10 days: I am crossing the Albanian border tomorrow morning

[opoudjis]

Express is crashing when I compile this with the latest gems:

/Users/nickn/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/expressir-2.1.6/lib/expressir/express/visitor.rb:210:in `node_find': asciidoctor: FAILED: documents/iso-13584-20/document.adoc: Failed to load AsciiDoc document - undefined method `find' for an instance of String (NoMethodError)

          node.find(path)
              ^^^^^
	from /Users/nickn/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/expressir-2.1.6/lib/expressir/express/visitor.rb:215:in `find_remark_target'
	from /Users/nickn/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/expressir-2.1.6/lib/expressir/express/visitor.rb:275:in `block in attach_rem

--- which is possibly pointing to an issue with one of the notes in Express. And when I compile a standalone document with this, I cannot replicate it:

So at this point, I cannot help you. I can tell that what is happening is that it is failing to remove the note wrapper in postprocessing in standoc, because it doesn't think that this is a terms clause. But in a standalone context, with == Terms and definitions clause, it processes them fine.

I cannot debug this unless I can compile this specific document, and right now, I cannot compile this specific document because of whatever is happening in Express. Please make sure it compiles your side, and let me know.

[opoudjis]

downgrade to expressir 1.4.3, it compiles. will work on this tomorrow