Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Styling issues with NOTEs and Requirements #97

Closed
ronaldtse opened this issue Aug 20, 2024 · 6 comments
Closed

PDF: Styling issues with NOTEs and Requirements #97

ronaldtse opened this issue Aug 20, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

Missing indents and spacing:

Screenshot 2024-08-20 at 5 53 51 PM
@ronaldtse ronaldtse added the bug Something isn't working label Aug 20, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Aug 20, 2024
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Aug 20, 2024
@Intelligent2013
Copy link
Contributor

@ronaldtse could you point me the PDF page or source adoc? Just I can't find these fragments... Thanks.

@ReesePlews
Copy link

hi @Intelligent2013 for this project the original documents are:

  • mn-samples-plateau/reference-docs/plateau_doc_0002_ver04.pdf
  • mn-samples-plateau/reference-docs/plateau_doc_0001_ver04.pdf

however the client has accepted a lot of change proposals suggested by @ronaldtse to harmonize the styles of the two documents.

Nick has implemented all of the proposed changed which are, or soon will be in the Plateau flavor.

hope that helps

@Intelligent2013
Copy link
Contributor

Current requirements rendering. For instance:

[requirements_class]
.拡張製品仕様書作成時の留意事項
====
[%metadata]
identifier:: /req/decision
subject:: 3D都市モデル
description:: 拡張製品仕様書作成時の留意事項
requirement:: /att/decision/1
requirement:: /att/decision/2
requirement:: /att/decision/3
requirement:: /att/decision/4
requirement:: /att/decision/5
requirement:: /att/decision/6
requirement:: /att/decision/7
requirement:: /att/decision/8
requirement:: /att/decision/9
====

Resulted PDF:
image

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Aug 21, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Aug 21, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Aug 21, 2024

Plateau XSLT updated (will be available in the metanorma-plateau repository in 30 minutes) for NOTEs:
image

@github-project-automation github-project-automation bot moved this from 🌋 Urgent to ✅ Done in Metanorma Aug 21, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Metanorma Aug 22, 2024
@Intelligent2013
Copy link
Contributor

The issue occurs for note in the document 02 v4:

Property ID "_85191d18-6048-e88d-1830-45e1b3a5db4a" (found on "fo:block-container") previously used; ID values must be unique within a document! (See position 2210:235)
org.apache.fop.fo.ValidationException: Property ID "_85191d18-6048-e88d-1830-45e1b3a5db4a" (found on "fo:block-container") previously used; ID values must be unique within a document! (See position 2210:235)
javax.xml.transform.TransformerException: org.apache.fop.fo.ValidationException: Property ID "_85191d18-6048-e88d-1830-45e1b3a5db4a" (found on "fo:block-container") previously used; ID values must be unique within a document! (See position 2210:235)
	at org.apache.xalan.transformer.TransformerIdentityImpl.transform

XSL-FO fragment:

<fo:block-container role="SKIP" id="fig-2-1">
	<fo:block role="SKIP">
		<fo:block role="SKIP" text-align="center">
			<fo:external-graphic fox:alt-text="Image " src="....
					</fo:block>
					<fo:block-container text-indent=" 0mm" space-before="2pt" role="SKIP" id="_85191d18-6048-e88d-1830-45e1b3a5db4a" margin-top="6pt" margin-bottom="6pt">
				<fo:block-container role="SKIP" margin-right="0mm" margin-left="0mm">
					<fo:table border="1pt solid black" width="99%" table-layout="fixed">
						<fo:table-body>
							<fo:table-row>
								<fo:table-cell padding="2mm">
									<fo:block role="SKIP" margin-bottom="10pt" keep-with-next="always">注記</fo:block>
									<fo:block>
										<fo:block text-align="justify" margin-bottom="10pt" id="_ea539342-252f-e361-e2e1-d1c5cab0b69e"> 新規の<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデル整備では、重複整備の排除による費用の削減や管理・更新のしやすさの観点から、既存データを有効に活用することが望ましい。そのため、<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備においても各種法定図書の整備に伴い収集・整備する資料・データを把握し、これらの利用を前提としたうえで、ユースケースに不足する場合には測量や現地調査等により新規に取得する手順としている。</fo:block>
										<fo:block text-align="justify" margin-bottom="10pt" id="_5fee4997-c63d-7544-cc74-5ef13d272f41"> 一方で、既存資料の多くは<fo:inline font-family="Noto Sans Condensed" font-weight="300">2</fo:inline>次元での利用を前提としており、地図や表形式での利用が主体となる。そのため、これらの資料は必ずしも<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備(<fo:inline font-family="Noto Sans Condensed" font-weight="300">3</fo:inline>次元での座標の記述や、オブジェクト単位でのデータの管理)に適した形態ではない場合がある。</fo:block>
										<fo:block text-align="justify" margin-bottom="0pt" id="_1235a717-7e96-72d7-13cd-a98142ccbab9"> 効率的な<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備に向けて、都市計画基本図や都市計画基礎調査等の法定図書の整備においても、今後はこれを考慮した整備(例:まず<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルを整備し、これから都市計画基本図や都市計画基礎調査の図や表を成型する)や更新サイクル(例:都市計画基本図と都市計画基礎調査の実施年度を一致させる)が望まれる。</fo:block>
									</fo:block>
								</fo:table-cell>
							</fo:table-row>
						</fo:table-body>
					</fo:table>
				</fo:block-container>
			</fo:block-container>
		</fo:block>
		<fo:block-container text-indent="0mm" space-before="2pt" role="SKIP" id="_85191d18-6048-e88d-1830-45e1b3a5db4a">
			<fo:block-container role="SKIP" margin-right="0mm" margin-left="0mm">
				<fo:block>
					<fo:inline role="SKIP">注記</fo:inline>
					<fo:block text-align="justify" margin-bottom="10pt" id="_ea539342-252f-e361-e2e1-d1c5cab0b69e"> 新規の<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデル整備では、重複整備の排除による費用の削減や管理・更新のしやすさの観点から、既存データを有効に活用することが望ましい。そのため、<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備においても各種法定図書の整備に伴い収集・整備する資料・データを把握し、これらの利用を前提としたうえで、ユースケースに不足する場合には測量や現地調査等により新規に取得する手順としている。</fo:block>
					<fo:block text-align="justify" margin-bottom="10pt" id="_5fee4997-c63d-7544-cc74-5ef13d272f41"> 一方で、既存資料の多くは<fo:inline font-family="Noto Sans Condensed" font-weight="300">2</fo:inline>次元での利用を前提としており、地図や表形式での利用が主体となる。そのため、これらの資料は必ずしも<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備(<fo:inline font-family="Noto Sans Condensed" font-weight="300">3</fo:inline>次元での座標の記述や、オブジェクト単位でのデータの管理)に適した形態ではない場合がある。</fo:block>
					<fo:block text-align="justify" margin-bottom="0pt" id="_1235a717-7e96-72d7-13cd-a98142ccbab9"> 効率的な<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルの整備に向けて、都市計画基本図や都市計画基礎調査等の法定図書の整備においても、今後はこれを考慮した整備(例:まず<fo:inline font-family="Noto Sans Condensed" font-weight="300">3D</fo:inline>都市モデルを整備し、これから都市計画基本図や都市計画基礎調査の図や表を成型する)や更新サイクル(例:都市計画基本図と都市計画基礎調査の実施年度を一致させる)が望まれる。</fo:block>
				</fo:block>
			</fo:block-container>
		</fo:block-container>

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Aug 23, 2024
@Intelligent2013
Copy link
Contributor

Fixed.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants