Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIPM xslt: known issues, Part 4 #274

Closed
Intelligent2013 opened this issue Oct 30, 2020 · 19 comments
Closed

BIPM xslt: known issues, Part 4 #274

Intelligent2013 opened this issue Oct 30, 2020 · 19 comments
Assignees
Labels
bug Something isn't working

Comments

@Intelligent2013
Copy link
Contributor

From metanorma/bipm-si-brochure#40

  1. Page 4(fr): the accents of the French words are all at wrong places: too high, too much on the left
    изображение

  2. Page 10(fr) In the title the accents on "à" and "édition" seem to be placed too high

изображение

  1. Page 15(fr) 2nd line above table 1: the negative exponents are not at the same height as the positive ones. Applies to many other places in the text

jEuclid bug?

изображение

  1. Change a space before ToC to move 5.4.8 on the previous page:
    изображение
@Intelligent2013 Intelligent2013 added the bug Something isn't working label Oct 30, 2020
@Intelligent2013 Intelligent2013 self-assigned this Oct 30, 2020
@Intelligent2013
Copy link
Contributor Author

From metanorma/bipm-si-brochure#41
5. Page 24(fr) Table 4: 3re column vertically not well aligned with 1st and 2nd column:

изображение

@Intelligent2013
Copy link
Contributor Author

From metanorma/bipm-si-brochure#42
6. Page 42(fr) Don't repeat header except 'Page':
изображение

  1. Page 49(fr) Check page break before 5.:
    изображение

  2. Page 50(fr) replace "remarque" by "note"

изображение

@Intelligent2013
Copy link
Contributor Author

From metanorma/bipm-si-brochure#44

  1. Page 88(fr) "Les valeurs" too far on the left:

изображение

@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Oct 31, 2020

  1. and 2. are not xslt issues. The issue in adoc and xml - there are a characters with accent/acutes as separated characters, i.e. for example:

Latin Small Letter E With Acute has a hex code E9:
изображение

but in the source adoc it encoded as e and hex code 301 (Combining Acute Accent)
== Preface à la 9^e^ édition
изображение

изображение

It's a bug in FOP: https://issues.apache.org/jira/browse/FOP-2969

Intelligent2013 added a commit that referenced this issue Oct 31, 2020
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Oct 31, 2020

  1. Page 50(fr) replace "remarque" by "note"

Fixed.

Intelligent2013 added a commit that referenced this issue Oct 31, 2020
@Intelligent2013
Copy link
Contributor Author

  1. Change a space before ToC to move 5.4.8 on the previous page:

Fixed:
изображение

@Intelligent2013
Copy link
Contributor Author

  1. Page 15(fr) 2nd line above table 1: the negative exponents are not at the same height as the positive ones. Applies to many other places in the text

изображение

The reason of misaligment between 2 and -2 in the max height of previous chars - k has a more height than other chars g m, therefore 2 shows a bit higher.
I've checked how it displays in MathJax (https://www.mathjax.org/#demo), and it shows similar (but with less differences):
изображение

Intelligent2013 added a commit that referenced this issue Nov 1, 2020
@Intelligent2013
Copy link
Contributor Author

  1. Page 49(fr). page break before 5..

Fixed:
изображение

@Intelligent2013
Copy link
Contributor Author

  1. Page 24(fr) Table 4: 3re column vertically not well aligned with 1st and 2nd column:

изображение

To fix this issue there is a property relative-align (https://www.w3.org/TR/xsl/#relative-align), but Apache FOP doesn't support it (https://xmlgraphics.apache.org/fop/compliance.html#fo-property-relative-align).

Need to find a workaround solution.

Intelligent2013 added a commit that referenced this issue Nov 2, 2020
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Nov 2, 2020

  1. Page 24(fr) Table 4: 3re column vertically not well aligned with 1st and 2nd column:

Fixed.

  1. For table cell set line-stacking-strategy="font-height".
  2. Font size for math in table decreased to 95% to look identical as main text.

изображение

@Intelligent2013
Copy link
Contributor Author

From metanorma/bipm-si-brochure#43 (comment)
10. In the equation:
изображение
2 doesn't display as superscripted.

Original:
eq-original

@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Nov 2, 2020

To do via xslt (original comment see metanorma/bipm-si-brochure#43 (comment)):

  • <mtext> </mtext> -> <mspace width="0.5ex" height="1ex"/>
  • <mtext/> -> <mspace height="1ex"/>

For testing purpose, create a simple xsl-fo table for comparing all math equations in bipm brochure:

  • left column with math equations as is;
  • right column with processed math equations.

Intelligent2013 added a commit that referenced this issue Nov 3, 2020
@Intelligent2013
Copy link
Contributor Author

Issue 10 fixed.
Now it displays:
изображение

Fixed for equations:
si-brochure-fr.presentation.mtext.pdf

@Intelligent2013
Copy link
Contributor Author

  1. Difference in rendering equation in text

изображение

and in a separated pdf:

изображение

Superscripted and subscripted items looks a bit smaller in the second case.

Intelligent2013 added a commit that referenced this issue Nov 3, 2020
@Intelligent2013
Copy link
Contributor Author

  1. Fixed. Now it displays with smaller font-size:
    изображение

The equation in the text rendered in font-size=9pt, but in a separated pdf (it used in 10. for testing purposes) in 11pt, therefore it looked differently. By default, the minimum font-size for scripted text is 8pt. It decreased to 6pt.

Intelligent2013 added a commit that referenced this issue Nov 8, 2020
@Intelligent2013
Copy link
Contributor Author

  1. Page 88(fr) "Les valeurs" too far on the left:
    Fixed:
    изображение

Intelligent2013 added a commit that referenced this issue Nov 8, 2020
Intelligent2013 added a commit that referenced this issue Nov 8, 2020
@Intelligent2013
Copy link
Contributor Author

  1. Page 15(fr) 2nd line above table 1: the negative exponents are not at the same height as the positive ones. Applies to many other places in the text

Fixed:
изображение
by adding <mathml:mspace height="1.4ex"/> after first <mrow>.

@Intelligent2013
Copy link
Contributor Author

All issues, except 6., fixed.

  1. Page 42(fr) Don't repeat header except 'Page':

Solution proposed here: metanorma/bipm-si-brochure#42 (comment)

@ronaldtse
Copy link
Contributor

Thank you @Intelligent2013 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants