Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the requests.session #107

Closed
JulienPalard opened this issue Sep 15, 2020 · 2 comments · Fixed by #109
Closed

Closing the requests.session #107

JulienPalard opened this issue Sep 15, 2020 · 2 comments · Fixed by #109

Comments

@JulienPalard
Copy link
Contributor

JulienPalard commented Sep 15, 2020 •
edited
Loading

OsmApi should provide a .close() method to close the underlying _session object, to avoid ResourceWarning: unclosed <ssl.SSLSocket warnings.

It could also provide a __enter__ and a __exit__, to implicitly call the close at exit.
@metaodi
Copy link
Owner

metaodi commented Sep 15, 2020

Related to #89

@metaodi metaodi mentioned this issue Oct 4, 2020
Merged
@metaodi
Copy link
Owner

metaodi commented Oct 4, 2020

The fix is part of release 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a context manager to manage session handling metaodi/osmapi
2 participants
@JulienPalard @metaodi