-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CORS headers #271
Support CORS headers #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It would be better to add
HEADERS
inServer
class to do it once before server port open. - We should support old versions of impress and config files, so we can't expect that
config.server.cors.origin
is present, need a dynamic check and use it only if it exists.
Moving all |
OK, do I need to delete the last commit before pushing the new implementation? Or do I need to just make a new fixup for this commit: 2125df0? |
@MarhiievHE it is not important, I'll squash all commits to single landing this PR |
Landed in 9b96150 |
metarhia/impress#1687 (comment)
npm t
)npm run fmt
)