-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Meteor to use code from this repository for Blaze distributed with Meteor releases #20
Comments
For now, Blaze doesn't really have a separated versioning. Should we have an independent versioning system? |
I think it does and I also think this was one of the core goals with splitting some (all) packages from Meteor. |
Every Meteor release gets a bump. That wouldn't be ideal for a separated package. |
I think that would not be needed anymore, this is one of those changes they are working on. |
I don't think MDG should ship Blaze (or any view layer for that matter) with Meteor in the first place. I'd rather make it all optional as they do now with React since v1.3 for example. |
I think they will have to do so for foreseeable future (at least until they go to Meteor 2.0). And also we will have to keep backwards compatibility for that purpose. We can (as a community) go and do Blaze 2. But we and MDG also have responsibility for current users using Blaze 1. In any case that's their call to make and I am operating on what they have expressed until now (Blaze gets extracted out, gets its own versioning, Meteor ships with that Blaze). If you hear other plans, please do report them here. :-) |
I'm just pessimistic by nature and MDG has been known for abruptly changing their mind ;) |
OK, let's be more optimistic in the future, there is enough bad feelings around Meteor already. So, let's get community to go through tickets and see which are still relevant. This is only on us. If you are more optimistic about community, then feel free to organize this part. |
I was (trying to be) sarcastic ;) I wouldn't be here if it wasn't for my optimism! ;) Lets hear what community has to say. |
Sorry, a bit long day. Didn't catch that. |
@mitar is there anyone from MDG watching this repo? I think Blaze 1 has some serious potential. It would be nice if we could add an option like $ meteor upgrade blaze Essentially the proposed script combines both requirements above, and would pull from the official repo to replace Blaze 1 |
+1 Blaze has some good potential inside and I think a symlink to this repo in their own repo would be quite useful to forget about shared versioning system and dependencies. |
They are, you can see them here. :-) |
@mitar ok, cool. let me know what i can do |
A loose plan for 1.4 is to depend on Blaze via the app's |
@zol, @benjamn: What does this comment mean for the future of this repository? It seems that community involvement in Blaze will again suffer and not move anywhere. I see that there are some potential changes to Blaze repository going in as fixes in Meteor repository, not here. I really worry that this delays of switching Meteor to use this repository will make put all this into a limbo and Blaze will not be able to move anywhere, which will effectively kill it. Not just that MDG is not investing time into Blaze anymore, but now even community seems to not be able to do so. Can I propose a intermediate solution? Make meteor repository use git submodules to pull these packages here into the main repository and let's start working here on Blaze as a community. Later on, when you finish with NPM integration, we can improve things. But waiting for NPM integration and everything else seems like putting all those plans we had for Blaze and community stewardship of Blaze in jeopardy. |
Agreed, many of us depend on Blaze and are not switching any time soon. There has to be an alternative when MDG changes its mind (again!) |
@mitar Meteor 1.4's package unpinning feature will allow us to completely move blaze development over to the community repo without waiting for npm integration. |
Why wasn't @mitar aware of this before so we could have moved forward on this project? Was/is this the only roadblock to moving forward? |
@zol: Great to hear that. So, could we make this transition happen with 1.4 release? Can you then remove the code which is in this repository from Meteor repository? I think this would be a great signal that everything is ready to start in this repository. So for now then we would keep Blaze pure-Meteor packages and continue with this until Meteor has better NPM integration. So my proposal for steps is:
How does this sound? (edit: I wrote "related packages", but it should be "related issues") |
|
@aadamsx: Most of this things have already been discussed in other issues. I would invite you to check about site and documentation in those issues. Also process on transferring Blaze issues (not packages, that was a typo) have already been started. About the governance. I think for now I would first like to see who is at all interested in contributing. And if can operate with rough consensus. If it becomes complicated, we can have a longer discussion. For now I would simply publish packages from this repository and I would like that this is possible - make one release where there are not really much changes (maybe just what is already there + fix for Chrome, meteor/meteor#6793). |
Is the code in this repo up-to-date? |
It should be. We should of course check that. But when I was last checking it was. |
Meteor 1.4 is has been released. @mitar is there any prep that needs to take place in order to get started using this community repo for Blaze? Do you have guidance on using the new unpinning feature that will allow us to completely move blaze development over to the community repo without waiting for npm integration? ... Using Meteor 1.1 or another target release of Meteor? |
We would just release Blaze as a Meteor package. But we first have to get permissions to do so. So, @zol, what's the plan here? |
Yeah, we talked about this a little bit. There are a couple of implications of removing these packages from
[1] A simpler option is to just use a submodule and keep including the latest version of Blaze in every Meteor release, but this seems like a half-way house. Perhaps we can keep it as a back up plan in case any of the above are deal breakers. What do you think @mitar / et al? |
There's also a minor philosophical problem that this list of packages includes |
I think the full change to Could we maybe change |
I think if we were going to do that we should probably just go the whole hog: if you depend on a non-core package from another package (where the list of core packages is shrinking and will continue to shrink over time), you have to specify some kind of version constraint, or there's an error. |
Any progress on this front? |
Hi! These packages are now gone from the mainline meteor repo! meteor/meteor#7633 🎉 |
(See also #56) |
Yea!!! OK, we should then probably create now a Blaze Meteor development team, and get it access to publishing packages from this repo to Atmosphere. |
And how we should go about updating changelog in meteor about Blaze related things? Or should we just maintain it here? |
[1] Not 100% true because some core packages depend on these packages but you can safely ignore that in thinking about this. |
I created OK, then we will handle one changelog in this repository. Yea! |
Maintainer added! |
Let me know if you have thoughts on how best to tell people to look at the Blaze changelog. |
Yea! I think we should just make an entry in Meteor's changelog to point them here and this is it? One more question: how will documentation (http://docs.meteor.com/) be done now? Is it pulled from here? Or should we setup something independent? |
I mean, definitely this, but I'm wondering if there's more we can do. Something prominent here: https://atmospherejs.com/meteor/blaze would be good too I think.
For now, yes, it will pull from here (as I bump a submodule). If you set up something independent, we should point people there though, given the decoupling of the releases. |
I opened #57. |
No description provided.
The text was updated successfully, but these errors were encountered: