Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rerun helpers when an #each cursor limit changes #41

Closed
lorensr opened this issue May 19, 2016 · 3 comments
Closed

Don't rerun helpers when an #each cursor limit changes #41

lorensr opened this issue May 19, 2016 · 3 comments

Comments

@lorensr
Copy link

lorensr commented May 19, 2016

Migrated from meteor/meteor#4960

When the argument to {{#each}} changes between different cursors, we treat the transition as if it is a change between two arrays. Since {{#each}} works with arbitrary arrays, we don't diff the items in the array. Instead, we inform all of the rendered items that their contents have changed (even though they likely haven't). This means many helpers will fire but their contents will stay the same.

The elegant solution in the framework would be to make minimongo smarter, giving it the intelligence to reuse materialized query results. You could imagine a minimongo that internally keeps ReactiveArrays of some sort that are updated incrementally and sliced and projected as needed for the purposes of queries.

@mitar
Copy link
Contributor

mitar commented May 19, 2016

Can you expand description? Copy it over, make a summary?

@mitar
Copy link
Contributor

mitar commented Jan 6, 2017

It would be great to have a reproduction here.

@filipenevola
Copy link
Collaborator

I'm closing this issue because it's too old.

If you think this issue is still relevant please open a new one.

Why? We need to pay attention to all the open items so we should keep opened only items where people are involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants