Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we catch errors in main or in implementation files? #124

Closed
adisidev opened this issue Mar 4, 2022 · 3 comments
Closed

Should we catch errors in main or in implementation files? #124

adisidev opened this issue Mar 4, 2022 · 3 comments
Assignees
@adisidev
Labels
enhancement New feature or request priority: high

Comments

@adisidev
Copy link
Collaborator

adisidev commented Mar 4, 2022

For instance, shall we include the file reading error in read_csv instead of main?
@adisidev
Copy link
Collaborator Author

adisidev commented Mar 4, 2022

Additionally, what is the purpose of including a try-catch block over check_topology?

@adisidev
Copy link
Collaborator Author

We should catch them in implementation files as to not clutter main. Either #167 or another future pull request should deal with this soon.

@adisidev adisidev self-assigned this Sep 19, 2024
@adisidev adisidev added enhancement New feature or request priority: high labels Sep 19, 2024
@adisidev adisidev mentioned this issue Sep 20, 2024
Closed
@adisidev
Copy link
Collaborator Author

Similar to #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adisidev adisidev

Labels
enhancement New feature or request priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adisidev