Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether we want to create a flags object inside inset_state (to pass around flags) #189

Open
adisidev opened this issue Aug 5, 2024 · 1 comment
Assignees

Comments

@adisidev
Copy link
Collaborator

adisidev commented Aug 5, 2024

Suggested sensibly by @nihalzp

One potential caveat is that it would hide away some options for some functions to within the functions (i.e. instead of calling function(flag = true) it would become just function(), which might make it confusing in the future what all possibilities exist in the function.

On a related note, we should add the parameter names to the .hpp files, so one can easily look at what all functions are available, and what the parameters actually mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant