Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document not (yet) implemented features #5

Open
frederikschubert opened this issue Dec 17, 2015 · 4 comments
Open

Document not (yet) implemented features #5

frederikschubert opened this issue Dec 17, 2015 · 4 comments

Comments

@frederikschubert
Copy link

I read your article on your blog (http://blog.mgechev.com/2015/10/26/angular2-hot-loader-hot-loading-tooling/) and saw that there are some missing features that you documented.
I think it would be helpful to create issues for them here in this repo to gain more insight in the current capabilities and shortcomings of the hot-loader.
I don't know whether the list you gave in your article is still valid and wanted to ask you which of those are already implemented.

@mgechev
Copy link
Owner

mgechev commented Dec 17, 2015

Yes, I think it is out-of-date. More specifically, which features do you mean?

@frederikschubert
Copy link
Author

I think the patching of the component's constructor does not work yet.
Also I read something in your code regarding the @RouteConfig decorator. Does this fix the issue you mentioned in your article?
I don't know if it is possible but it would be nice to load new components/files that have been created after the page has been loaded.
Also thank you for your great work! This project would make developing angular applications much more enjoyable.

@mgechev
Copy link
Owner

mgechev commented Dec 18, 2015

Thanks for the kind words! Yes, constructors doesn't work yet. Haven't tested it with @RouteConfig but it may actually work with the latest changes. I think the entire metadata associated to the component is being updated.

I don't know if it is possible but it would be nice to load new components/files that have been created after the page has been loaded.

Should be possible. At this point my main focus is to achieve stability of the current set of features and to make the code more readable :-)

Would you open issues for the features you'd like to use? Also if you'd enjoy it - feel free to open another PR with new features/bug fixes.

@frederikschubert
Copy link
Author

Alright! I think I will spend some time playing around with the hot-loader during the holidays :). Then I will really see which features are needed and will create issues (and if I can PRs) for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants