Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenated callables treated as union type, used to be skipped on RenderCallbackRule #543

Closed
Boegie opened this issue Apr 28, 2023 · 0 comments · Fixed by #544
Closed

Concatenated callables treated as union type, used to be skipped on RenderCallbackRule #543

Boegie opened this issue Apr 28, 2023 · 0 comments · Fixed by #544
Labels
bug Something isn't working

Comments

@Boegie
Copy link
Contributor

Boegie commented Apr 28, 2023 •
edited by mglaman
Loading

Bug report

Created by #529

Discovered in https://www.drupal.org/project/drupal/issues/3357114.

\Drupal\Tests\Core\Render\RendererTest::testRenderWithAccessControllerResolved used to pass, but not any more.

+		-
+			message: "#^\\#access_callback callback class 'Drupal\\\\\\\\Tests\\\\\\\\Core…' at key '0' does not implement Drupal\\\\Core\\\\Security\\\\TrustedCallbackInterface\\.$#"
+			count: 4
+			path: tests/Drupal/Tests/Core/Render/RendererTest.php

"Interestingly", when replacing the variable with all possible strings, it still passes.

Code snippet that reproduces the problem

See test cases in PR #544.
@Boegie Boegie added the bug Something isn't working label Apr 28, 2023
@Boegie Boegie mentioned this issue Apr 28, 2023
Merged
@mglaman mglaman changed the title Regression due to #529 Concatenated callables treated as union type, used to be skipped on RenderCallbackRule May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support concatenated callables in RenderCallbackRule Boegie/phpstan-drupal
1 participant
@Boegie