Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore LoadIncludes rule if module and file name unknown #524

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Ignore LoadIncludes rule if module and file name unknown #524

merged 3 commits into from
Apr 7, 2023

Conversation

Boegie
Copy link
Contributor

@Boegie Boegie commented Apr 7, 2023

Fixes #516

mglaman
mglaman approved these changes Apr 7, 2023
View reviewed changes
Copy link
Owner

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reviewed via mobile, I'll merge when I can get to my laptop and give it one more look over

@mglaman mglaman changed the title 516 Ignore LoadIncludes rule if module and file name unknown Apr 7, 2023
@mglaman mglaman merged commit 21b6249 into mglaman:main Apr 7, 2023
@Boegie Boegie deleted the 516 branch April 7, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglaman mglaman mglaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives from loadInclude rule
2 participants
@Boegie @mglaman