Add translatable interface stub for content entities #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need some advice on how to approach the failure in the baseline test. |
mglaman
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
I think it's fine to provide the stub for TranslatableInterface. I think it's worth backporting the fix here for others.
As for the baseline failures for Drupal core: we can ignore those, I noticed that as well. There was a change in PHPStan I guess which broke the baseline. Or only in this project's CI.
|
Thank you! |
simonbaese
added a commit
to simonbaese/phpstan-drupal
that referenced
this pull request
Jul 18, 2023
Add TranslatableInterface stub (mglaman#588)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stub for the
TranslatableInterface. Note that this stub will be unnecessary for Drupal 10.1+ (see https://www.drupal.org/project/drupal/issues/3269177). Nevertheless, it may be useful for users that run a prior version of Drupal.This change is a little bit aggressive because it creates a stub for the
TranslatableInterfacedirectly, although only tests for content entities are provided. We could be more passive by basing the stub on theContentEntityBase.