Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty "in:" in Trace and Warn with happyDevFormatter #21

Open
mwmahlberg opened this issue Jan 7, 2016 · 5 comments
Open

Empty "in:" in Trace and Warn with happyDevFormatter #21

mwmahlberg opened this issue Jan 7, 2016 · 5 comments

Comments

@mwmahlberg
Copy link

When calling Warn() or Trace() only with a string, the happyDevFormatter prints an empty "in:" at the end of the line.

The according code in the happyDeFormatter.go does not seem to trigger.

@mgutz
Copy link
Owner

mgutz commented May 9, 2016

Should have a fix in the next couple of days. The stack format changed in 1.6. Just so I have notes when I work on this:

go 1.5

/usr/src/myapp/main.go:9 (0x401024)
    main: fmt.Println(string(debug.Stack()))
/usr/local/go/src/runtime/proc.go:111 (0x429190)
    main: main_main()
/usr/local/go/src/runtime/asm_amd64.s:1721 (0x455a11)
    goexit: BYTE    $0x90   // NOP

go 1.6

goroutine 1 [running]:
runtime/debug.Stack(0x0, 0x0, 0x0)
    /usr/local/go/src/runtime/debug/stack.go:24 +0x80
main.main()
    /usr/src/myapp/main.go:9 +0x24

@huangyingyi
Copy link

Is this fixed yet?

@AlbinoGeek
Copy link

Nope, still not fixed.

@coopernurse
Copy link

@AlbinoGeek I see you have a more active fork of this project. Would you be open to receiving patches on your fork and perhaps cutting some release tags periodically?

If so I'll put a note on #47 about that.

@AlbinoGeek
Copy link

Sounds good. I use this package in all my projects, it's probably time to give back, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants