Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat custom scalars as Js.Json.t #2

Closed
wokalski opened this issue Sep 7, 2017 · 0 comments
Closed

Treat custom scalars as Js.Json.t #2

wokalski opened this issue Sep 7, 2017 · 0 comments

Comments

@wokalski
Copy link
Contributor

wokalski commented Sep 7, 2017

Custom scalars are sometimes unavoidable if working with an existing system. I suggest that we should treat custom scalars as Js.Json.t and let the user decode/encode them accordingly. In the future we're probably gonna need another solution but it's good enough for now IMO.

@ulrikstrid played with a POC implementation which works fine but we couldn't get parameters to work. What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wokalski