From 0ffa44e838d77e6b93ede5244d7e4f4e72e0973e Mon Sep 17 00:00:00 2001
From: Mouhamed DIOP <mouhamed.diop@esp.sn>
Date: Tue, 17 Jan 2023 17:10:16 +0000
Subject: [PATCH] STYLE: Mark translatable strings in Base/QTApp

See https://github.com/Slicer/SlicerLanguagePacks/issues/12
---
 Base/QTApp/qSlicerAboutDialog.cxx |  3 ++-
 Base/QTApp/qSlicerMainWindow.cxx  | 14 +++++++-------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/Base/QTApp/qSlicerAboutDialog.cxx b/Base/QTApp/qSlicerAboutDialog.cxx
index 540d33da7a9..7bd0d547071 100644
--- a/Base/QTApp/qSlicerAboutDialog.cxx
+++ b/Base/QTApp/qSlicerAboutDialog.cxx
@@ -72,7 +72,8 @@ qSlicerAboutDialog::qSlicerAboutDialog(QWidget* parentWidget)
         }
       }
 #else
-    d->CreditsTextBrowser->insertHtml("Visit the <a href=\"https://download.slicer.org/\">download site</a> to check if a new version is available.");
+    QString downloadSiteLink = QString("<a href=\"https://download.slicer.org/\">%1</a>").arg(tr("download site"));
+    d->CreditsTextBrowser->insertHtml(tr("Visit the %1 to check if a new version is available.").arg(downloadSiteLink));
     d->CreditsTextBrowser->append("");
 #endif
     d->CreditsTextBrowser->append("");
diff --git a/Base/QTApp/qSlicerMainWindow.cxx b/Base/QTApp/qSlicerMainWindow.cxx
index 49e00252f62..f916c24b523 100644
--- a/Base/QTApp/qSlicerMainWindow.cxx
+++ b/Base/QTApp/qSlicerMainWindow.cxx
@@ -190,7 +190,7 @@ void qSlicerMainWindowPrivate::setupUi(QMainWindow * mainWindow)
   // ModuleSelector ToolBar
   //----------------------------------------------------------------------------
   // Create a Module selector
-  this->ModuleSelectorToolBar = new qSlicerModuleSelectorToolBar("Module Selection",q);
+  this->ModuleSelectorToolBar = new qSlicerModuleSelectorToolBar(qSlicerMainWindow::tr("Module Selection"),q);
   this->ModuleSelectorToolBar->setObjectName(QString::fromUtf8("ModuleSelectorToolBar"));
   this->ModuleSelectorToolBar->setAllowedAreas(Qt::TopToolBarArea | Qt::BottomToolBarArea);
   this->ModuleSelectorToolBar->setModuleManager(moduleManager);
@@ -300,7 +300,7 @@ void qSlicerMainWindowPrivate::setupUi(QMainWindow * mainWindow)
 #ifdef Slicer_USE_QtTesting
   // we store this layout manager to the Object state property for QtTesting
   qSlicerApplication::application()->testingUtility()->addObjectStateProperty(
-      qSlicerApplication::application()->layoutManager(), QString("layout"));
+      qSlicerApplication::application()->layoutManager(), QString(/*no tr*/"layout"));
   qSlicerApplication::application()->testingUtility()->addObjectStateProperty(
       this->ModuleSelectorToolBar->modulesMenu(), QString("currentModule"));
 #endif
@@ -454,7 +454,7 @@ void qSlicerMainWindowPrivate::setupUi(QMainWindow * mainWindow)
     else
       {
       ctkPythonConsole* pythonConsole = q->pythonConsole();
-      pythonConsole->setWindowTitle("Slicer Python Console");
+      pythonConsole->setWindowTitle(qSlicerMainWindow::tr("Slicer Python Console"));
       pythonConsole->resize(600, 280);
       pythonConsole->hide();
       this->PythonConsoleToggleViewAction = new QAction("", this->ViewMenu);
@@ -568,7 +568,7 @@ void qSlicerMainWindowPrivate::setupRecentlyLoadedMenu(const QList<qSlicerIO::IO
   // Add separator and clear action
   this->RecentlyLoadedMenu->addSeparator();
   QAction * clearAction = this->RecentlyLoadedMenu->addAction(
-    "Clear History", q, SLOT(onFileRecentLoadedActionTriggered()));
+    qSlicerMainWindow::tr("Clear History"), q, SLOT(onFileRecentLoadedActionTriggered()));
   clearAction->setProperty("clearMenu", QVariant(true));
 }
 
@@ -877,7 +877,7 @@ void qSlicerMainWindow::on_ShowStatusBarAction_triggered(bool toggled)
 //---------------------------------------------------------------------------
 void qSlicerMainWindow::on_FileFavoriteModulesAction_triggered()
 {
-  qSlicerApplication::application()->openSettingsDialog("Modules");
+  qSlicerApplication::application()->openSettingsDialog(qSlicerApplication::tr("Modules"));
 }
 
 //---------------------------------------------------------------------------
@@ -999,7 +999,7 @@ void qSlicerMainWindow::on_FileCloseSceneAction_triggered()
     qSlicerCoreApplication::application()->mrmlScene()->SetURL("");
     // Set default scene file format to .mrml
     qSlicerCoreIOManager* coreIOManager = qSlicerCoreApplication::application()->coreIOManager();
-    coreIOManager->setDefaultSceneFileType("MRML Scene (.mrml)");
+    coreIOManager->setDefaultSceneFileType(tr("MRML Scene") + " (.mrml)");
     }
 }
 
@@ -1388,7 +1388,7 @@ void qSlicerMainWindow::on_LoadDICOMAction_triggered()
     {
     return;
     }
-  layoutManager->setCurrentModule("DICOM");
+  layoutManager->setCurrentModule(/*no tr*/"DICOM");
 }
 
 //---------------------------------------------------------------------------