Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "set-output" command is deprecated and will be disabled soon warning #42

Closed
pysel opened this issue Nov 14, 2022 · 11 comments · Fixed by #44
Closed

The "set-output" command is deprecated and will be disabled soon warning #42

pysel opened this issue Nov 14, 2022 · 11 comments · Fixed by #44

Comments

@pysel
Copy link

pysel commented Nov 14, 2022

More info here

Every pull request on Osmosis finishes with this warning. Seems like this action is responsible for it. Ex: example
From the first link, my guess it is due to not using @actions/core v1.10.0 but may be something else

@pysel pysel changed the title Theset-output command is deprecated and will be disabled soon warniong Theset-output command is deprecated and will be disabled soon warning Nov 14, 2022
@pysel pysel changed the title Theset-output command is deprecated and will be disabled soon warning The"set-output" command is deprecated and will be disabled soon warning Nov 14, 2022
@pysel pysel changed the title The"set-output" command is deprecated and will be disabled soon warning The "set-output" command is deprecated and will be disabled soon warning Nov 14, 2022
@pysel
Copy link
Author

pysel commented Nov 14, 2022

I checked this action and it seems like nowhere here set-output nor save-state are being used, so if you have any ideas why it might happen, I would be really thankful for any info!

@pysel
Copy link
Author

pysel commented Nov 14, 2022

might be due to this

@jakemhiller
Copy link

Yeah, actions/core just needs to be updated

@mheap
Copy link
Owner

mheap commented Nov 15, 2022

I'm using https://github.com/JasonEtco/actions-toolkit for this, which needs to bump its version of actions/core. I'm working on a solution and it'll be shipped way before the EOL date for the existing functionality

@longrunningprocess
Copy link

I'm using https://github.com/JasonEtco/actions-toolkit for this, which needs to bump its version of actions/core. I'm working on a solution and it'll be shipped way before the EOL date for the existing functionality

just checking in on this, did I understand you correctly that you'll fix it rather than asking Jason to update his? I didn't notice an issue for it over in his repo and I'm not sure it's being worked on anymore. Thanks!

@mheap
Copy link
Owner

mheap commented Dec 24, 2022

just checking in on this, did I understand you correctly that you'll fix it rather than asking Jason to update his?

Yep! I'm slowly converting actions to @actions/core and @actions/github. This is on my list for the holiday break 👍

@longrunningprocess
Copy link

😎 , appreciate it man!

@longrunningprocess
Copy link

just curious, I presume this will still be released under v2, is that what you're thinking?

@mheap
Copy link
Owner

mheap commented Dec 27, 2022

I'm reasonably confident this will be a v2 update. If there are any changes which could be considered breaking (I don't intend to make any, but it all depends on the implementation) it'll go out as v3

@mheap
Copy link
Owner

mheap commented Dec 30, 2022

I released this as v3 as v2 has code to handle the neutral exit code which no longer exists. @actions/core doesn't support it, and rather than adding custom code to handle something that isn't used, I chose to remove the neutral exit_type. This necessitated a major release

@longrunningprocess
Copy link

make sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants