Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With v6.0.18, Sidekiq doesn't run at all #471

Closed
blanchma opened this issue Mar 8, 2020 · 3 comments
Closed

With v6.0.18, Sidekiq doesn't run at all #471

blanchma opened this issue Mar 8, 2020 · 3 comments
Assignees
Labels

Comments

@blanchma
Copy link

blanchma commented Mar 8, 2020

Describe the bug
The sidekiq process run but no jobs are processed.

Expected behavior
A job is enqueued. A job is processed.

Current behavior
No job is processed with or without unique locks.

Worker class

class SidekiqHealthJob
  include Logging
  include Sidekiq::Worker

  def perform
    UniqueJob.perform_async

    redis = Configuration.redis
    sidekiq_health = Configuration.redis.get "sidekiq_health"

    if sidekiq_health && 5.minute.ago.to_i < sidekiq_health.to_i
      true
    elsif sidekiq_health
      false
      Rollbar.error("Sidekiq Health Job run last time #{Time.at(sidekiq_health)}")
    else
      Rollbar.error("Sidekiq Health Job never ran")
    end
  end

  class UniqueJob
    include Logging
    include Sidekiq::Worker
    sidekiq_options(retry: 3, lock_expiration: 10, unique: :until_executing)

    def perform
      sidekiq_health = Configuration.redis.set "sidekiq_health", Time.now.to_i
    end
  end
end

Additional context
sidekiq (6.0.4)
connection_pool (>= 2.2.2)
rack (>= 2.0.0)
rack-protection (>= 2.0.0)
redis (>= 4.1.0)
sidekiq-unique-jobs (6.0.18)
concurrent-ruby (> 1.0, >= 1.0.5)
sidekiq (>= 4.0, < 7.0)
thor (
> 0)

ruby 2.5.7

If a downgrade to 6.0.13 to work again.

@mhenrixon mhenrixon self-assigned this Mar 17, 2020
@mhenrixon mhenrixon added the bug label Mar 17, 2020
@mhenrixon
Copy link
Owner

Seems related to #435

@mhenrixon
Copy link
Owner

If you change to sidekiq_options(retry: 3, lock_expiration: 10, lock: :until_executing) it should work properly @blanchma

@mhenrixon
Copy link
Owner

Fixed in v6.0.19 and I also yanked the broken gems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants