Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing? #12

Open
dcormier opened this issue Jan 17, 2020 · 4 comments
Open

Contributing? #12

dcormier opened this issue Jan 17, 2020 · 4 comments

Comments

@dcormier
Copy link

dcormier commented Jan 17, 2020

Is there any interest in accepting contributions? I have a need for a package like this, but I also need more functionality than this currently provides. Not only to be able to deal with additional API endpoints, but things like context.Context support and being able to specify an http.Client to use (http.DefaultClient doesn't have a timeout on it, so should be used with caution; I generally avoid it).

Is there any interest in this sort of thing being contributed back to this repo?

@dcormier
Copy link
Author

Some of these changes are included in #13.

@mhoc
Copy link
Owner

mhoc commented Jan 29, 2020

Hi! I really appreciate you finding a bit of value in this.

To be honest; while I really would love to find the time to develop this out further, I don't see that happening on the near-term. The underlying projects I was working on where this work would have been applied have moved to languages other than Go, which have active Graph API libraries. I will definitely update the README to make that clear.

It would probably be best if you forked it and Made It Your Own, so to speak. If you end up doing this, I'm happy to update the README to point to your repository, so no one gets too confused about the ecosystem as it stands. Last I checked there still isn't a great Go library for the Graph API, so I'm sure we could use one.

Again, really appreciate the time you took on that PR.

@dcormier
Copy link
Author

Understood. I definitely know how that goes.

I've got a fork with these changes in master at dcormier/msgoraph. I haven't changed the readme and such as I anticipated the changed being merged in over here. I'll need to update the import paths to make it its own package, but that's not a big deal.

@dcormier
Copy link
Author

dcormier commented Feb 4, 2020

OK, there's a fork that works over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants