Sign-in with Github is not working

[barrosfelipe]

Issue:

When I click the sign-in with Github link it shows a pop-up and the pop-up quickly vanishes without any result (it doesn't ask me for my Github credentials or connects to my Github login so that I can authorize the application), returning me to the application in its previous state.

I've opened maria.cloud inside a Firefox container, the same container where I'm logged into my Github account. I'm not sure if this information is relevant but it may interfere somehow.

Environment:

• Browser: Firefox 59.0 (64-bit)
• Platform (Mac/Windows/Linux): Linux

URL to a gist replicating the issue (if possible/relevant)

[ImmoStanke]

This seems to be related to cookie settings. I have the same issue when disallowing third party cookies. Console log tells you this as well:
uncaught exception: Error: This browser is not supported or 3rd party cookies and data may be disabled.

Unfortunately it's not possible (or I don't know how) to allow third party cookies only for a specific page.
Containers may help there though to get a better trade-off between usability and privacy.
If you enable third party cookies completely, it works for me (Firefox 59.0.2 (64-bit)) on Windows.

So as a workaround, you can enable third-party cookies, connect maria repl to github, and disable them again.

[practicalli-johnny]

We had the same issue with Chrome on one of the students laptops at this weekends ClojureBridge London event. There was a cookie manager plugin which seemed to keep blocking regardless.

Using a Chrome incognito window resolved the issue.