-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downloading shared photos from shared album #344
Conversation
@mib1185 could you take a look at this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first thanks for this contribution 👍
There are some formatting issues (see failing CI) which needs to be solved first (easiest way is to use the VSCode dev container). Further there are some typing issues (mypy issues on the CI) which should be solved by the comments below.
From technical point of view, i cannot really verify it, since i do not use the photos station in such way - maybe @lodesmets (sorry for pinging you again 🙈) could also have a look?
As soon as you've done all changes, please press the "Ready for review" button, thx 👍
Hi, thanks for the feedback, requested changes has been done. |
Hey, @alexismarquis, @mib1185 Looks good. I tested it, And it still seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexismarquis
again many thanks, we are close to be ready for merge, just some small comments.
@lodesmets thanks for your testing and review efforts 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @alexismarquis 👍
Breaking Change
This will extend the classes
SynoPhotosAlbum
andSynoPhotosItem
by an editional property calledpassphrase
which should set toNone
if the item or album is not shared by others or set to the corresponding passphrase when it is shared.Context :
Shared album have a
passphrase
field that is used in the public sharing link. It is also required by the download and thumbnail api methods.See home-assistant/core#120817 for more detail.
This PR adds passphrase handling, fixing downloading photos from different users in shared albums.
Additionally, it addresses a problem I encountered with HEIC photos that return an
application/octet-stream
content type.Fixes #299