Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to specify requirements of notebook #2

Open
zyxue opened this issue Feb 18, 2020 · 3 comments
Open

Is it necessary to specify requirements of notebook #2

zyxue opened this issue Feb 18, 2020 · 3 comments

Comments

@zyxue
Copy link

zyxue commented Feb 18, 2020

I see you only specified requirement("notebook"), I wonder if it's necessary to specify the dependencies/requirements of notebook in `deps, too?
https://github.com/michael-quinlan/jupyter-bazel/blob/master/notebooks/BUILD#L8

@michael-quinlan
Copy link
Owner

Yes any additional deps you have need to be specified.

@zyxue
Copy link
Author

zyxue commented Feb 26, 2020

Is this considered a bug, as bazel doc explicitly says

What this means for BUILD file writers is that every rule must explicitly declare all of its actual direct dependencies to the build system, and no more.

@smamessier
Copy link

@zyxue This is indeed a bug of the rules_python repo (See this PR that proposes a temporary solution: bazelbuild/rules_python#198)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants