Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorthand PHP Usage #5

Open
iwarner opened this issue Feb 6, 2012 · 2 comments
Open

Shorthand PHP Usage #5

iwarner opened this issue Feb 6, 2012 · 2 comments

Comments

@iwarner
Copy link

iwarner commented Feb 6, 2012

Would advise against this in a tool for others to use - system may not have this enabled

I will fork and fix if you wish to merge.

@michael-romer
Copy link
Owner

This would be brilliant. I do agree with avoiding shorthand usage. So I'm happy to merge in your pull requests.

@iwarner
Copy link
Author

iwarner commented Feb 7, 2012

Michael are you going to support in the future both version 1 and 2 of Zend? I will fix in the 2 strand first, decided after playing with 2 that it doesn't quite work yet in terms of the modules - so piling through version 1 now.

I can see a lack of Doc Blocks throughout the whole code? Would you want these fleshed out also?

In my CodeBlender layer I would pull out these types of config into the application.ini

var _gaq=[['_setAccount','UA-XXXXX-X'],['_trackPageview']];

I can certainly help with some housekeeping tasks on this.

Let me know your thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants