Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Polly" unsigned by default and migrate signed to "Polly-Signed" #5

Closed
ghuntley opened this issue Mar 11, 2014 · 1 comment
Closed

Comments

@ghuntley
Copy link
Contributor

Hi Michael,

I'd like to propose to introduce a breaking change where by Polly is not
strong named by default. i.e. increment the semver major.

The migration path for existing users who are using strong-names would to be to
migrate to a separate nuget package. i.e.

Signed versions of the client libraries are also available at:

    PM> Install-Package Polly-Signed

This is the path that other OSS packages are taking:

etc.

Important note Binding Redirect is not available w/clients that consume Portable Class Libraries:

Suplemental material:

Thoughts?
Geoff

@michael-wolfenden
Copy link
Contributor

Geoff,

I am happy to go ahead with this change.

My preference is for unsigned assemblies but at the time there were no
clear nuget standards on naming the signed / unsigned packages, so I went
for the lesser evil and strongly named the library.

Michael
On 12/03/2014 7:17 AM, "Geoffrey Huntley" notifications@github.com wrote:

Hi Michael,

I'd like to propose to introduce a breaking change where by Polly is not
strong named by default. i.e. increment the semver major.

The migration path for existing users who are using strong-names would to
be to
migrate to a separate nuget package. i.e.

Signed versions of the client libraries are also available at:

PM> Install-Package Polly-Signed

This is the path that other OSS packages are taking:

etc.

Important note binding Redirect is not available w/Portable Class
Libraries:

https://stackoverflow.com/questions/12337378/is-bindingredirect-supported-in-silverlight-windows-phone-and-metro

https://wpdev.uservoice.com/forums/110705-app-platform/suggestions/2511980-assembly-binding-redirection-support

Suplemental material:

Thoughts,
Geoff


Reply to this email directly or view it on GitHubhttps://github.com//issues/5
.

joelhulen pushed a commit that referenced this issue Jun 2, 2016
* Add Polly.Net40Async project for async support

- Polly.NET40Async references Nuget package Microsoft.Bcl.Async
- Add conditional compiler constant SUPPORTS_ASYNC_40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants