Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: functions and throw statements are underlined even if caught #81

Merged
merged 2 commits into from
Dec 17, 2023
Merged

fix: functions and throw statements are underlined even if caught #81

merged 2 commits into from
Dec 17, 2023

Conversation

michaelangeloio
Copy link
Owner

@michaelangeloio michaelangeloio commented Dec 17, 2023 •
edited
Loading

closes #71

Summary of Changes

  • Adds a new setting called includeTryStatementThrows. If enabled, the linter will also mark errors under try/catch statements
  • This behavior is now false as default
  • Added some tests for this fix

Notes

  • This should have been default behavior from the get-go, so I am marking this as a patch change.
    • A test has been added under main.rs for the main does-it-throw crate to ensure this backwards compatibility

@michaelangeloio michaelangeloio merged commit 16adf85 into main Dec 17, 2023
2 checks passed
@michaelangeloio michaelangeloio deleted the issue#71 branch December 17, 2023 01:33
@github-actions github-actions bot mentioned this pull request Dec 17, 2023
Merged
@michaelangeloio michaelangeloio mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions and throw statements are underlined even if caught
1 participant
@michaelangeloio