Fixes tests and updates dry validation version #2
Conversation
| @@ -164,7 +164,7 @@ def define_assurances_hook | |||
|
|
|||
| after do | |||
| assurances = self.class.assurances.new | |||
| result = assurances.call(context) | |||
| result = assurances.call(context.to_h) | |||
There was a problem hiding this comment.
Was this throwing an error? Since the Interactor::Context object is based on OpenStruct, it used to be handled automatically by dry-validation. I would rather rely on dry-validation's handling of OpenStructs if possible.
I'm guessing it was due to how the required macro works?
There was a problem hiding this comment.
Yes, when I started testing it it was raising a NoMethodError: undefined method key?' for, it seems dry-validation started checking for keys using #key?` method which doesn't exist in OpenStruct neither Context.
| @@ -189,7 +189,7 @@ def define_expectations_hook | |||
|
|
|||
| before do | |||
| expectations = self.class.expectations.new | |||
| result = expectations.call(context) | |||
| result = expectations.call(context.to_h) | |||
There was a problem hiding this comment.
Same as above with the other call to #to_h.
| require "codeclimate-test-reporter" | ||
| CodeClimate::TestReporter.start | ||
| require 'simplecov' | ||
| SimpleCov.start |
There was a problem hiding this comment.
We should get the codeclimate-test-reporter to work again, but that's outside the scope of this right now.
I tried to use this project and ended up getting some errors, I started investigating the causes and noticed the dry validation used was old, and there were some errors in spec_helper (related to SimpleCov configuring).