Add Danger as a collaboration tool #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelherold
changed the title
Danger helps open source maintainers to ensure that certain things are done by contributors. This helps the maintainers more easily check to make sure that contributors (including themselves) are following the contributing guidelines.
By enabled Danger, we enable the installation of Rubocop on the CI environment. Rubocop depends on the "rainbow" library which has a build error on certain versions of RubyGems. This has been fixed in newer versions of RubyGems, so let's just update RubyGems prior to trying to install anything. See: ku1ik/rainbow#44 See: rubygems/rubygems#1819
This is related to the RakeBuilder problem with building the rainbow library. Basically, Rake needs to be installed in order to build external dependencies. This is an attempt to make sure that Rake is installed.
michaelherold
force-pushed
the
add-danger
branch
2 times, most recently
from
7828780
to
7e1ce2f
Compare
jruby-9.0.0.0 was having build errors with pry, so let's try a newer version.
michaelherold
force-pushed
the
add-danger
branch
from
7e1ce2f
to
9eb9236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danger helps open source maintainers to ensure that certain things are
done by contributors. This helps the maintainers more easily check to
make sure that contributors (including themselves) are following the
contributing guidelines.